Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump bat-native-ads dep #3528

Closed
tmancey opened this issue Feb 28, 2019 · 1 comment · Fixed by brave/brave-core#1807
Closed

Bump bat-native-ads dep #3528

tmancey opened this issue Feb 28, 2019 · 1 comment · Fixed by brave/brave-core#1807
Assignees
@tmancey
Labels
feature/ads QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.63.x - Release ...

Comments

@tmancey
Copy link
Contributor

tmancey commented Feb 28, 2019 •
edited
Loading

fixes brave-intl/bat-native-ads#146
requires brave-intl/bat-native-ads#147

QA should test that state is not reset in Default/ads_service/client.json after browser restart
@tmancey tmancey added this to the 0.63.x - Nightly milestone Feb 28, 2019
@tmancey tmancey self-assigned this Feb 28, 2019
@tmancey tmancey mentioned this issue Feb 28, 2019
Merged
@tmancey tmancey added the QA/Yes label Feb 28, 2019
@tmancey tmancey mentioned this issue Feb 28, 2019
Merged
19 tasks
@srirambv
Copy link
Contributor

srirambv commented Apr 4, 2019 •
edited by btlechowski
Loading

Verification passed on

Brave 0.63.31 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Linux
  • Verfied client.json state is not lost in between browser restarts

Verified passed with

Brave 0.63.31 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Mac OS X
  • Verified client.json state is not lost in between browser restarts

Verification passed on

Brave 0.63.31 Chromium: 73.0.3683.75 (Official Build) beta (64-bit)
Revision 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS Windows 10 OS Build 17134.523
  • Verified client.json state is not lost in between browser restarts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
feature/ads QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.63.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Bump bat-native-ads dep brave/brave-core
5 participants
@tmancey @rebron @srirambv @LaurenWags @btlechowski