Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Remove cross promo dialog #42942

Closed
deeppandya opened this issue Dec 17, 2024 · 1 comment · Fixed by brave/brave-core#27052
Closed

[Android] Remove cross promo dialog #42942

deeppandya opened this issue Dec 17, 2024 · 1 comment · Fixed by brave/brave-core#27052
Assignees
@deeppandya
Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.75.x - Release

Comments

@deeppandya
Copy link
Contributor

In this issue, we are reverting the change we did for : #10571.
@deeppandya deeppandya added OS/Android Fixes related to Android browser functionality QA/Yes release-notes/include labels Dec 17, 2024
@deeppandya deeppandya self-assigned this Dec 17, 2024
@deeppandya deeppandya mentioned this issue Dec 18, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.75.x - Nightly milestone Dec 26, 2024
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 16, 2025
@hffvld
Copy link
Contributor

hffvld commented Jan 16, 2025

Verified on Galaxy Z Fold 6 using version(s):

Device/OS: Galaxy Z Fold 6 / q6quew-user 14 UP1A.231005.007 release-keys
Brave build: 1.75.159
Chromium: 132.0.6834.83 (Official Build) beta (64-bit)

STEPS:

  1. Fresh install Brave
  2. Go through onboarding
  3. Close Brave
  4. Change the device date to 2 weeks from today
  5. Launch Brave > Verify

ACTUAL RESULTS:

  • Verified that the cross promo dialog is removed and not shown anymore.
2025-01-16_15-26-05.mp4

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 16, 2025
@hffvld hffvld mentioned this issue Feb 6, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Milestone
1.75.x - Release
Development

Successfully merging a pull request may close this issue.

Remove cross promo dialog brave/brave-core
3 participants
@deeppandya @brave-builds @hffvld