Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chromium upgrade CL 6249551 cleanup #44237

Closed
darkdh opened this issue Feb 26, 2025 · 3 comments · Fixed by brave/brave-core#27522
Closed

Chromium upgrade CL 6249551 cleanup #44237

darkdh opened this issue Feb 26, 2025 · 3 comments · Fixed by brave/brave-core#27522
Assignees
@darkdh
Labels
Chromium/Followup Followup work logged during Chromium rebase Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix dev-concern feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA/No release-notes/exclude
Milestone
1.77.x - Release

Comments

@darkdh
Copy link
Member

darkdh commented Feb 26, 2025 •
edited
Loading

We cherry-picked https://chromium-review.googlesource.com/c/chromium/src/+/6249551 into core in brave/brave-core#27548.
This is the placeholder to make sure we cleanup leftover properly when we bump for chromium 135.0.7035.0
@darkdh darkdh self-assigned this Feb 26, 2025
@darkdh darkdh added the Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix label Feb 26, 2025
@darkdh darkdh mentioned this issue Feb 26, 2025
Merged
24 tasks
@darkdh darkdh added the Chromium/Followup Followup work logged during Chromium rebase label Feb 27, 2025
@emerick
Copy link
Contributor

emerick commented Mar 3, 2025

cc: @mkarolin @cdesouza-chromium, just since this is cr135-related

@cdesouza-chromium
Copy link
Contributor

I've already deleted these patches in cr135.

@mkarolin mkarolin mentioned this issue Mar 3, 2025
Merged
24 tasks
@darkdh
Copy link
Member Author

darkdh commented Mar 3, 2025

thanks @cdesouza-chromium for doing that in brave/brave-core@09a0b2d
but could you also delete chromium_src/components/download/public/background_service/url_loader_factory_getter.h?
It was added to address new file added patch.

@brave-builds brave-builds added the feature/web3/wallet Integrating Ethereum+ wallet support label Mar 19, 2025
@brave-builds brave-builds added this to the 1.78.x - Nightly milestone Mar 19, 2025
@mkarolin mkarolin mentioned this issue Mar 19, 2025
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkdh darkdh

Labels
Chromium/Followup Followup work logged during Chromium rebase Chromium/waiting upstream Issue is in Chromium; we'll likely wait for the fix dev-concern feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.77.x - Release
Development

Successfully merging a pull request may close this issue.

Upgrade from Chromium 134 to Chromium 135 brave/brave-core
6 participants
@emerick @rebron @darkdh @cdesouza-chromium @mkarolin @brave-builds