Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Top sites to Top suggestions #44592

Open
2 of 6 tasks
rebron opened this issue Mar 11, 2025 · 0 comments · May be fixed by brave/brave-core#28094
Open
2 of 6 tasks

Update Top sites to Top suggestions #44592

rebron opened this issue Mar 11, 2025 · 0 comments · May be fixed by brave/brave-core#28094

Comments

@rebron
Copy link
Collaborator

rebron commented Mar 11, 2025

Description

We expanded local device search suggestions with this issue #43762 in 1.77.x. Some users may want to turn local device search suggestions off. We think enabling/disabling this feature should be combined with Top sites which is our initial implementation of offering local suggestions via a top sites list.

The change is to relabel the Autocomplete suggestions setting from Top sites to Top suggestions and tie local device search suggestions to this setting.

Top suggestions will continue to be default enabled. When disabled, both top sites and local device search suggestions will be turned off and will not appear in the url bar.

Note that the brave://settings/search Improve search suggestions setting works independently and Top suggestions can be turned off while Improve search suggestions remains enabled. Further, search suggestions provided by the search engine takes precedence over the local device search suggestions.

Users will need to turn off both Top suggestions and Improve search suggestions to hide search suggestions fully from the url bar.

Steps to reproduce

  1. Go to brave://settings/appearance
  2. Setting should be Top suggestions
  3. Toggling on/off will enable/disable showing of top sites or search suggestions

Actual result

Image

Expected result

[placeholder]

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.77.x

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

Related issue: #44428
No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

2 participants