Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace direct patch for BraveBookmarkActivity with bytecode patch #44641

Open
6 tasks
samartnik opened this issue Mar 13, 2025 · 0 comments
Open
6 tasks

Replace direct patch for BraveBookmarkActivity with bytecode patch #44641

samartnik opened this issue Mar 13, 2025 · 0 comments
Assignees
Labels
dev-concern OS/Android Fixes related to Android browser functionality QA/No release-notes/exclude

Comments

@samartnik
Copy link
Contributor

Description

This is a follow up for C135 changes, where we directrly patch code for launching BraveBookmarkActivity (brave/brave-core@d697f09). We should instead extend Intent class and replace activity to launch within BraveIntent.

Steps to reproduce

  1. n/a

Actual result

n/a

Expected result

n/a

Reproduces how often

Easily reproduced

Brave version

n/a

Device

  • Brand/model: n/a
  • Android version: n/a

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev-concern OS/Android Fixes related to Android browser functionality QA/No release-notes/exclude
Projects
None yet
Development

No branches or pull requests

1 participant