Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uphold auto contribute has incorrect processor in DB #8938

Closed
LaurenWags opened this issue Mar 31, 2020 · 3 comments · Fixed by brave/brave-core#4869
Closed

Uphold auto contribute has incorrect processor in DB #8938

LaurenWags opened this issue Mar 31, 2020 · 3 comments · Fixed by brave/brave-core#4869

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #8571

When you have a KYC'd wallet connected, the processor in the DB should be 2 for Uphold. One time and recurring tips have correct processor of 2, but AC does not, it has 0.

Steps to Reproduce

  1. Clean profile, staging, short reconcile interval
  2. Enable rewards, connect KYC'd wallet (have BAT in the wallet to do ac and tips.)
  3. Do one time tip, set up recurring tip.
  4. Add verified sites to AC table.
  5. Wait for AC to go thru and complete.
  6. Close Brave.
  7. Open publisher_info_db and go to contribution_info table.

Actual result:

AC line has processor 0
Screen Shot 2020-03-31 at 12 12 17 PM

Expected result:

AC should have processor 2 like one time and recurring tips

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.8.55 Chromium: 81.0.4044.83 (Official Build) nightly (64-bit)
Revision 5718ca617723806b9aacfb41108a0d911d1bde74-refs/branch-heads/4044@{#853}
OS macOS Version 10.14.6 (Build 18G3020)
Brave 1.7.79 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? unsure
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @NejcZdovc

@GeetaSarvadnya
Copy link

Reproduced in windows 10 x64 - 1.7.82

image

@btlechowski
Copy link

Reproduced on

Brave 1.7.82 Chromium: 80.0.3987.162 (Official Build) dev (64-bit)
Revision f2c5dd6138153bb0658091205bd1a1717f16081a-refs/branch-heads/3987@{#1034}
OS Ubuntu 18.04 LTS

image

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 27, 2020

Verification passed on


Brave | 1.10.74 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

Verification passed on

Brave 1.10.79 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Ubuntu 18.04 LTS
  • Verified STR from the description

image


Verified passed with

Brave | 1.10.80 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Verified STR from description

Screen Shot 2020-06-02 at 3 34 33 PM

@rebron rebron changed the title uphold auto contribute has incorrect processor in DB Uphold auto contribute has incorrect processor in DB Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment