Skip to content

Commit 0532a57

Browse files
committed
Use a single sequenced task runner for HTTPSEverywehre
Otherwise we're creating lots of different threads and accessing things for the DB on different possibly overlapping threads I think this also fixes: brave/brave-browser#707 brave/brave-browser#708 brave/brave-browser#739 brave/brave-browser#797 brave/brave-browser#761 brave/brave-browser#762 brave/brave-browser#796 brave/brave-browser#797 brave/brave-browser#798 brave/brave-browser#861
1 parent 58f99af commit 0532a57

File tree

1 file changed

+8
-12
lines changed

1 file changed

+8
-12
lines changed

browser/net/brave_httpse_network_delegate_helper.cc

+8-12
Original file line numberDiff line numberDiff line change
@@ -81,18 +81,14 @@ int OnBeforeURLRequest_HttpsePreFileWork(
8181
GetHTTPSURLFromCacheOnly(&request->url(), request->identifier(),
8282
ctx->new_url_spec)) {
8383
ctx->request_url = request->url();
84-
85-
scoped_refptr<base::SequencedTaskRunner> task_runner =
86-
base::CreateSequencedTaskRunnerWithTraits({base::MayBlock(),
87-
base::TaskShutdownBehavior::SKIP_ON_SHUTDOWN});
88-
task_runner->PostTaskAndReply(FROM_HERE,
89-
base::Bind(OnBeforeURLRequest_HttpseFileWork,
90-
base::Unretained(request), new_url, ctx),
91-
base::Bind(base::IgnoreResult(
92-
&OnBeforeURLRequest_HttpsePostFileWork),
93-
base::Unretained(request),
94-
new_url, next_callback, ctx)
95-
);
84+
g_brave_browser_process->https_everywhere_service()->
85+
GetTaskRunner()->PostTaskAndReply(FROM_HERE,
86+
base::Bind(OnBeforeURLRequest_HttpseFileWork,
87+
base::Unretained(request), new_url, ctx),
88+
base::Bind(base::IgnoreResult(
89+
&OnBeforeURLRequest_HttpsePostFileWork),
90+
base::Unretained(request),
91+
new_url, next_callback, ctx));
9692
return net::ERR_IO_PENDING;
9793
} else {
9894
if (!ctx->new_url_spec.empty()) {

0 commit comments

Comments
 (0)