Skip to content

Commit 7d8718e

Browse files
committed
update spec of sync devices/qr code/words modals
close brave/brave-browser#2724 close brave/brave-browser#2591 address brave/brave-browser#2567
1 parent 3f9ba6d commit 7d8718e

File tree

9 files changed

+160
-334
lines changed

9 files changed

+160
-334
lines changed

browser/ui/webui/brave_webui_source.cc

+17-21
Original file line numberDiff line numberDiff line change
@@ -439,21 +439,22 @@ void CustomizeWebUIHTMLSource(const std::string &name, content::WebUIDataSource*
439439
}
440440
}, {
441441
std::string("sync"), {
442-
{ "done", IDS_BRAVE_SYNC_SHARED_DONE_BUTTON },
442+
// Shared strings
443443
{ "remove", IDS_BRAVE_SYNC_SHARED_REMOVE_PARTIAL },
444444
{ "copied", IDS_BRAVE_SYNC_SHARED_COPIED_TEXT },
445445
{ "wordCount", IDS_BRAVE_SYNC_SHARED_WORD_COUNT_TEXT },
446446
{ "ok", IDS_BRAVE_SYNC_SHARED_OK_BUTTON },
447447
{ "cancel", IDS_BRAVE_SYNC_SHARED_CANCEL_BUTTON },
448448
{ "thisSyncChain", IDS_BRAVE_SYNC_SHARED_FROM_THIS_CHAIN_PARTIAL },
449+
{ "lookingForDevice", IDS_BRAVE_SYNC_SCAN_CODE_LOOKING_FOR_DEVICE_BUTTON },
450+
{ "viewSyncCode", IDS_BRAVE_SYNC_ENABLED_VIEW_CODE_BUTTON },
449451
// Enabled Content
450452
{ "braveSync", IDS_BRAVE_SYNC_ENABLED_BRAVE_TITLE },
451453
{ "syncChainDevices", IDS_BRAVE_SYNC_ENABLED_DEVICES_CHAIN_TITLE },
452454
{ "deviceName", IDS_BRAVE_SYNC_ENABLED_TABLE_DEVICE_NAME_TITLE },
453455
{ "thisDevice", IDS_BRAVE_SYNC_ENABLED_TABLE_THIS_DEVICE_TEXT },
454456
{ "addedOn", IDS_BRAVE_SYNC_ENABLED_TABLE_ADDED_ON_TITLE },
455457
{ "addDevice", IDS_BRAVE_SYNC_ENABLED_ADD_DEVICE_BUTTON },
456-
{ "viewSyncCode", IDS_BRAVE_SYNC_ENABLED_VIEW_CODE_BUTTON },
457458
{ "settingsTitle", IDS_BRAVE_SYNC_ENABLED_SETTINGS_TITLE },
458459
{ "settingsDescription", IDS_BRAVE_SYNC_ENABLED_SETTINGS_DESCRIPTION },
459460
{ "settings", IDS_BRAVE_SYNC_ENABLED_TABLE_SETTINGS },
@@ -466,7 +467,6 @@ void CustomizeWebUIHTMLSource(const std::string &name, content::WebUIDataSource*
466467
{ "syncDescription", IDS_BRAVE_SYNC_DISABLED_NEW_CHAIN_DESCRIPTION },
467468
{ "startSyncChain", IDS_BRAVE_SYNC_DISABLED_START_NEW_CHAIN_BUTTON },
468469
{ "enterSyncChainCode", IDS_BRAVE_SYNC_DISABLED_ENTER_CODE_BUTTON },
469-
{ "confirmSyncCode", IDS_BRAVE_SYNC_DISABLED_CONFIRM_CODE_BUTTON },
470470
// [modal] Enter Sync Code
471471
{ "enterSyncCode", IDS_BRAVE_SYNC_ENTER_CODE_TITLE },
472472
{ "enterSyncCodeDescription", IDS_BRAVE_SYNC_ENTER_CODE_DESCRIPTION },
@@ -483,27 +483,23 @@ void CustomizeWebUIHTMLSource(const std::string &name, content::WebUIDataSource*
483483
{ "deleteSyncDescription", IDS_BRAVE_SYNC_RESET_REMOVAL_INSTRUCTIONS },
484484
{ "startSyncChainHowTo", IDS_BRAVE_SYNC_RESET_START_NEW_INSTRUCTIONS },
485485
{ "areYouSure", IDS_BRAVE_SYNC_RESET_ARE_YOU_SURE_TITLE },
486-
// [modal] Add New Chain
487-
{ "scanThisCode", IDS_BRAVE_SYNC_NEW_CHAIN_MAIN_DESCRIPTION },
488-
{ "scanThisCodeHowTo", IDS_BRAVE_SYNC_NEW_CHAIN_MAIN_INSTRUCTIONS },
489-
{ "enterCodeWordsInstead", IDS_BRAVE_SYNC_NEW_CHAIN_MAIN_CODE_WORDS_BUTTON },
490-
{ "previous", IDS_BRAVE_SYNC_NEW_CHAIN_MAIN_PREVIOUS_BUTTON },
491-
{ "lookingForDevice", IDS_BRAVE_SYNC_NEW_CHAIN_MAIN_LOOKING_FOR_DEVICE_BUTTON },
492-
// [modal] Add New Chain (Camera Option)
493-
// [modal] Add New Chain (no Camera)
494-
{ "enterThisCode", IDS_BRAVE_SYNC_NEW_CHAIN_DESKTOP_TITLE },
495-
{ "mobileEnterThisCode", IDS_BRAVE_SYNC_NEW_CHAIN_MOBILE_TITLE },
496-
{ "syncChainCodeHowTo", IDS_BRAVE_SYNC_NEW_CHAIN_DESCRIPTION },
497-
{ "useCameraInstead", IDS_BRAVE_SYNC_NEW_CHAIN_USE_CAMERA_BUTTON },
486+
// [modal] Scan Code
487+
{ "scanThisCode", IDS_BRAVE_SYNC_SCAN_CODE_TITLE },
488+
{ "scanThisCodeHowToPartial1", IDS_BRAVE_SYNC_SCAN_CODE_DESCRIPTION_PARTIAL_1 },
489+
{ "scanThisCodeHowToPartial2", IDS_BRAVE_SYNC_SCAN_CODE_DESCRIPTION_PARTIAL_2 },
490+
{ "scanThisCodeHowToPartial3", IDS_BRAVE_SYNC_SCAN_CODE_DESCRIPTION_PARTIAL_3 },
491+
// [modal] View Code
492+
{ "chainCode", IDS_BRAVE_SYNC_VIEW_CODE_TITLE },
493+
{ "chainCodeDescriptionPartial1", IDS_BRAVE_SYNC_VIEW_CODE_DESCRIPTION_PARTIAL_1 },
494+
{ "chainCodeDescriptionPartial2", IDS_BRAVE_SYNC_VIEW_CODE_DESCRIPTION_PARTIAL_2 },
495+
{ "chainCodeDescriptionPartial3", IDS_BRAVE_SYNC_VIEW_CODE_DESCRIPTION_PARTIAL_3 },
496+
{ "useCameraInstead", IDS_BRAVE_SYNC_VIEW_CODE_USE_CAMERA_BUTTON },
497+
{ "qrCode", IDS_BRAVE_SYNC_VIEW_CODE_QR_CODE },
498498
// [modal] Choose Device Type
499-
{ "letsSync", IDS_BRAVE_SYNC_CHOOSE_DEVICE_NEW_DEVICE_TITLE },
500-
{ "chooseDeviceType", IDS_BRAVE_SYNC_CHOOSE_DEVICE_CHOOSE_DEVICE_TITLE },
499+
{ "letsSync", IDS_BRAVE_SYNC_CHOOSE_DEVICE_TITLE },
500+
{ "chooseDeviceType", IDS_BRAVE_SYNC_CHOOSE_DEVICE_DESCRIPTION },
501501
{ "phoneTablet", IDS_BRAVE_SYNC_CHOOSE_DEVICE_MOBILE_TITLE },
502502
{ "computer", IDS_BRAVE_SYNC_CHOOSE_DEVICE_COMPUTER_TITLE },
503-
// [modal] View Sync Code
504-
{ "qrCode", IDS_BRAVE_SYNC_VIEW_CODE_QR_CODE_TITLE },
505-
{ "wordCode", IDS_BRAVE_SYNC_VIEW_CODE_WORD_CODE_TITLE },
506-
{ "privateKey", IDS_BRAVE_SYNC_VIEW_CODE_PRIVATE_KEY_PHRASE },
507503
// errors
508504
{ "errorWrongCodeTitle", IDS_BRAVE_SYNC_ERROR_WRONG_CODE_TITLE },
509505
{ "errorWrongCodeDescription", IDS_BRAVE_SYNC_ERROR_WRONG_CODE_DESCRIPTION },

components/brave_sync/ui/BUILD.gn

-2
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@ import("//brave/components/common/typescript.gni")
33
transpile_web_ui("ui") {
44
inputs = [
55
"actions/sync_actions.ts",
6-
"components/modals/addNewChainCameraOption.tsx",
7-
"components/modals/addNewChainNoCamera.tsx",
86
"components/modals/deviceType.tsx",
97
"components/modals/enterSyncCode.tsx",
108
"components/modals/removeDevice.tsx",

components/brave_sync/ui/brave_sync.html

+2-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,8 @@
2222
<script src="/brave_sync.bundle.js"></script>
2323
<script src="/strings.js"></script>
2424
<style>
25-
html, body, #root { height: 100vh; }
25+
{# html, body, #root, #}
26+
#syncPage { height: 100vh; }
2627
</style>
2728
</head>
2829
<body>

components/brave_sync/ui/components/modals/addNewChainCameraOption.tsx

-122
This file was deleted.

components/brave_sync/ui/components/modals/addNewChainNoCamera.tsx

-81
This file was deleted.

0 commit comments

Comments
 (0)