Skip to content

Commit 848cec6

Browse files
bbondybbondy
committed
Remove remote resource requests from newtab webui
Fix brave/brave-browser#501 Fix brave/brave-browser#273
1 parent db46b27 commit 848cec6

24 files changed

+62
-36
lines changed

‎browser/ui/webui/brave_webui_source.cc

+22-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,28 @@ void CustomizeWebUIHTMLSource(const std::string &name, content::WebUIDataSource*
5353
{ "314e7529efec41c8867019815f4d8dad.svg", IDR_BRAVE_NEW_TAB_IMG4 },
5454
{ "6c337c63662ee0ba4e57f6f8156d69ce.svg", IDR_BRAVE_NEW_TAB_IMG2 },
5555
{ "50cc52a4f1743ea74a21da996fe44272.jpg", IDR_BRAVE_NEW_TAB_IMG14 },
56-
{ "b6dd4b1292cfd4470e58486c56ad0832.svg", IDR_BRAVE_NEW_TAB_PRIVATE_ICON }
56+
{ "b6dd4b1292cfd4470e58486c56ad0832.svg", IDR_BRAVE_NEW_TAB_PRIVATE_ICON },
57+
// New tab Backgrounds
58+
{ "dksfoto1.jpg", IDR_BRAVE_NEW_TAB_BACKGROUND1 },
59+
{ "dksfoto2.jpg", IDR_BRAVE_NEW_TAB_BACKGROUND2 },
60+
{ "dksfoto3.jpg", IDR_BRAVE_NEW_TAB_BACKGROUND3 },
61+
{ "dksfoto4.jpg", IDR_BRAVE_NEW_TAB_BACKGROUND4 },
62+
{ "dksfoto5.jpg", IDR_BRAVE_NEW_TAB_BACKGROUND5 },
63+
{ "dksfoto6.jpg", IDR_BRAVE_NEW_TAB_BACKGROUND6 },
64+
{ "dksfoto7.jpg", IDR_BRAVE_NEW_TAB_BACKGROUND7 },
65+
{ "dksfoto8.jpg", IDR_BRAVE_NEW_TAB_BACKGROUND8 },
66+
{ "dksfoto9.jpg", IDR_BRAVE_NEW_TAB_BACKGROUND9 },
67+
{ "dksfoto10.jpg", IDR_BRAVE_NEW_TAB_BACKGROUND10 },
68+
{ "dksfoto11.jpg", IDR_BRAVE_NEW_TAB_BACKGROUND11 },
69+
{ "Phoyoserge_Corsica.jpg", IDR_BRAVE_NEW_TAB_BACKGROUND12 },
70+
{ "Phoyoserge_Corsica2.jpg", IDR_BRAVE_NEW_TAB_BACKGROUND13 },
71+
{ "Phoyoserge_DowntownGriffith.jpg", IDR_BRAVE_NEW_TAB_BACKGROUND14 },
72+
{ "Phoyoserge_ElmatadorBeach.jpg", IDR_BRAVE_NEW_TAB_BACKGROUND15 },
73+
{ "Phoyoserge_ParisConciergeri.jpg", IDR_BRAVE_NEW_TAB_BACKGROUND16 },
74+
{ "Phoyoserge_Theroofparis.jpg", IDR_BRAVE_NEW_TAB_BACKGROUND17 },
75+
{ "Phoyoserge_TheSeantParis.jpg", IDR_BRAVE_NEW_TAB_BACKGROUND18 },
76+
{ "Phoyoserge_VeniseSunset.jpg", IDR_BRAVE_NEW_TAB_BACKGROUND19 },
77+
{ "Phoyoserge_Yosemite.jpg", IDR_BRAVE_NEW_TAB_BACKGROUND20 }
5778
}
5879
}, {
5980
std::string("welcome"), {

‎components/brave_new_tab_ui/backgrounds.js

+20-20
Original file line numberDiff line numberDiff line change
@@ -5,102 +5,102 @@
55
module.exports = [
66
{
77
'name': 'Tuolome Meadows',
8-
'source': 'https://s3.amazonaws.com/brave-backgrounds/dksfoto1.jpg',
8+
'source': 'dksfoto1.jpg',
99
'author': 'Darrell Sano',
1010
'link': 'https://dksfoto.smugmug.com'
1111
}, {
1212
'name': 'South Tufa, Mono Lake',
13-
'source': 'https://s3.amazonaws.com/brave-backgrounds/dksfoto2.jpg',
13+
'source': 'dksfoto2.jpg',
1414
'author': 'Darrell Sano',
1515
'link': 'https://dksfoto.smugmug.com'
1616
}, {
1717
'name': 'Little Lakes Valley',
18-
'source': 'https://s3.amazonaws.com/brave-backgrounds/dksfoto3.jpg',
18+
'source': 'dksfoto3.jpg',
1919
'author': 'Darrell Sano',
2020
'link': 'https://dksfoto.smugmug.com'
2121
}, {
2222
'name': 'Bay Bridge',
23-
'source': 'https://s3.amazonaws.com/brave-backgrounds/dksfoto4.jpg',
23+
'source': 'dksfoto4.jpg',
2424
'author': 'Darrell Sano',
2525
'link': 'https://dksfoto.smugmug.com'
2626
}, {
2727
'name': 'Yosemite',
28-
'source': 'https://s3.amazonaws.com/brave-backgrounds/dksfoto5.jpg',
28+
'source': 'dksfoto5.jpg',
2929
'author': 'Darrell Sano',
3030
'link': 'https://dksfoto.smugmug.com'
3131
}, {
3232
'name': 'Beach Ice',
33-
'source': 'https://s3.amazonaws.com/brave-backgrounds/dksfoto6.jpg',
33+
'source': 'dksfoto6.jpg',
3434
'author': 'Darrell Sano',
3535
'link': 'https://dksfoto.smugmug.com'
3636
}, {
3737
'name': 'Color and White Trunks',
38-
'source': 'https://s3.amazonaws.com/brave-backgrounds/dksfoto7.jpg',
38+
'source': 'dksfoto7.jpg',
3939
'author': 'Darrell Sano',
4040
'link': 'https://dksfoto.smugmug.com'
4141
}, {
4242
'name': 'Golden Gate Bridge',
43-
'source': 'https://s3.amazonaws.com/brave-backgrounds/dksfoto8.jpg',
43+
'source': 'dksfoto8.jpg',
4444
'author': 'Darrell Sano',
4545
'link': 'https://dksfoto.smugmug.com'
4646
}, {
4747
'name': 'Long Lake',
48-
'source': 'https://s3.amazonaws.com/brave-backgrounds/dksfoto9.jpg',
48+
'source': 'dksfoto9.jpg',
4949
'author': 'Darrell Sano',
5050
'link': 'https://dksfoto.smugmug.com'
5151
}, {
5252
'name': 'San Francisco Skyline',
53-
'source': 'https://s3.amazonaws.com/brave-backgrounds/dksfoto10.jpg',
53+
'source': 'dksfoto10.jpg',
5454
'author': 'Darrell Sano',
5555
'link': 'https://dksfoto.smugmug.com'
5656
}, {
5757
'name': 'Across Mono Basin',
58-
'source': 'https://s3.amazonaws.com/brave-backgrounds/dksfoto11.jpg',
58+
'source': 'dksfoto11.jpg',
5959
'author': 'Darrell Sano',
6060
'link': 'https://dksfoto.smugmug.com'
6161
}, {
6262
'name': 'Corsica',
63-
'source': 'https://s3.amazonaws.com/brave-backgrounds/Phoyoserge_Corsica.jpg',
63+
'source': 'Phoyoserge_Corsica.jpg',
6464
'author': 'Serge Ramelli',
6565
'link': 'https://www.photoserge.com/'
6666
}, {
6767
'name': 'Corsica',
68-
'source': 'https://s3.amazonaws.com/brave-backgrounds/Phoyoserge_Corsica2.jpg',
68+
'source': 'Phoyoserge_Corsica2.jpg',
6969
'author': 'Serge Ramelli',
7070
'link': 'https://www.photoserge.com/'
7171
}, {
7272
'name': 'Griffith Park Observatory (Downtown Los Angeles)',
73-
'source': 'https://s3.amazonaws.com/brave-backgrounds/Phoyoserge_DowntownGriffith.jpg',
73+
'source': 'Phoyoserge_DowntownGriffith.jpg',
7474
'author': 'Serge Ramelli',
7575
'link': 'https://www.photoserge.com/'
7676
}, {
7777
'name': 'Elmatador Beach',
78-
'source': 'https://s3.amazonaws.com/brave-backgrounds/Phoyoserge_ElmatadorBeach.jpg',
78+
'source': 'Phoyoserge_ElmatadorBeach.jpg',
7979
'author': 'Serge Ramelli',
8080
'link': 'https://www.photoserge.com/'
8181
}, {
8282
'name': 'Paris:Conciergeri',
83-
'source': 'https://s3.amazonaws.com/brave-backgrounds/Phoyoserge_ParisConciergeri.jpg',
83+
'source': 'Phoyoserge_ParisConciergeri.jpg',
8484
'author': 'Serge Ramelli',
8585
'link': 'https://www.photoserge.com/'
8686
}, {
8787
'name': 'Paris:The Roof',
88-
'source': 'https://s3.amazonaws.com/brave-backgrounds/Phoyoserge_Theroofparis.jpg',
88+
'source': 'Phoyoserge_Theroofparis.jpg',
8989
'author': 'Serge Ramelli',
9090
'link': 'https://www.photoserge.com/'
9191
}, {
9292
'name': 'Paris:The Seant',
93-
'source': 'https://s3.amazonaws.com/brave-backgrounds/Phoyoserge_TheSeantParis.jpg',
93+
'source': 'Phoyoserge_TheSeantParis.jpg',
9494
'author': 'Serge Ramelli',
9595
'link': 'https://www.photoserge.com/'
9696
}, {
9797
'name': 'Venise Sunset',
98-
'source': 'https://s3.amazonaws.com/brave-backgrounds/Phoyoserge_VeniseSunset.jpg',
98+
'source': 'Phoyoserge_VeniseSunset.jpg',
9999
'author': 'Serge Ramelli',
100100
'link': 'https://www.photoserge.com/'
101101
}, {
102102
'name': 'Yosemite',
103-
'source': 'https://s3.amazonaws.com/brave-backgrounds/Phoyoserge_Yosemite.jpg',
103+
'source': 'Phoyoserge_Yosemite.jpg',
104104
'author': 'Serge Ramelli',
105105
'link': 'https://www.photoserge.com/'
106106
}

‎components/img/newtab/Phoyoserge_Corsica.jpg

292 KB
Loading

‎components/img/newtab/Phoyoserge_Corsica2.jpg

244 KB
Loading

‎components/img/newtab/Phoyoserge_DowntownGriffith.jpg

252 KB
Loading

‎components/img/newtab/Phoyoserge_ElmatadorBeach.jpg

259 KB
Loading

‎components/img/newtab/Phoyoserge_ParisConciergeri.jpg

273 KB
Loading

‎components/img/newtab/Phoyoserge_TheSeantParis.jpg

320 KB
Loading

‎components/img/newtab/Phoyoserge_Theroofparis.jpg

415 KB
Loading

‎components/img/newtab/Phoyoserge_VeniseSunset.jpg

302 KB
Loading

‎components/img/newtab/Phoyoserge_Yosemite.jpg

401 KB
Loading

‎components/img/newtab/dksfoto1.jpg

627 KB
Loading

‎components/img/newtab/dksfoto10.jpg

160 KB
Loading

‎components/img/newtab/dksfoto11.jpg

300 KB
Loading

‎components/img/newtab/dksfoto2.jpg

308 KB
Loading

‎components/img/newtab/dksfoto3.jpg

255 KB
Loading

‎components/img/newtab/dksfoto4.jpg

129 KB
Loading

‎components/img/newtab/dksfoto5.jpg

528 KB
Loading

‎components/img/newtab/dksfoto6.jpg

371 KB
Loading

‎components/img/newtab/dksfoto7.jpg

574 KB
Loading

‎components/img/newtab/dksfoto8.jpg

202 KB
Loading

‎components/img/newtab/dksfoto9.jpg

375 KB
Loading

‎components/resources/brave_components_resources.grd

+20
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,26 @@
9595
<include name="IDR_BRAVE_NEW_TAB_IMG2" file="../img/newtab/settings_prefs_btn.svg" type="BINDATA" />
9696
<include name="IDR_BRAVE_NEW_TAB_IMG14" file="../img/newtab/newtab_stock_image.jpg" type="BINDATA" />
9797
<include name="IDR_BRAVE_NEW_TAB_PRIVATE_ICON" file="../img/newtab/private_tab_pagearea_icon.svg" type="BINDATA" />
98+
<include name="IDR_BRAVE_NEW_TAB_BACKGROUND1" file="../img/newtab/dksfoto1.jpg" type="BINDATA" />
99+
<include name="IDR_BRAVE_NEW_TAB_BACKGROUND2" file="../img/newtab/dksfoto2.jpg" type="BINDATA" />
100+
<include name="IDR_BRAVE_NEW_TAB_BACKGROUND3" file="../img/newtab/dksfoto3.jpg" type="BINDATA" />
101+
<include name="IDR_BRAVE_NEW_TAB_BACKGROUND4" file="../img/newtab/dksfoto4.jpg" type="BINDATA" />
102+
<include name="IDR_BRAVE_NEW_TAB_BACKGROUND5" file="../img/newtab/dksfoto5.jpg" type="BINDATA" />
103+
<include name="IDR_BRAVE_NEW_TAB_BACKGROUND6" file="../img/newtab/dksfoto6.jpg" type="BINDATA" />
104+
<include name="IDR_BRAVE_NEW_TAB_BACKGROUND7" file="../img/newtab/dksfoto7.jpg" type="BINDATA" />
105+
<include name="IDR_BRAVE_NEW_TAB_BACKGROUND8" file="../img/newtab/dksfoto8.jpg" type="BINDATA" />
106+
<include name="IDR_BRAVE_NEW_TAB_BACKGROUND9" file="../img/newtab/dksfoto9.jpg" type="BINDATA" />
107+
<include name="IDR_BRAVE_NEW_TAB_BACKGROUND10" file="../img/newtab/dksfoto10.jpg" type="BINDATA" />
108+
<include name="IDR_BRAVE_NEW_TAB_BACKGROUND11" file="../img/newtab/dksfoto11.jpg" type="BINDATA" />
109+
<include name="IDR_BRAVE_NEW_TAB_BACKGROUND12" file="../img/newtab/Phoyoserge_Corsica.jpg" type="BINDATA" />
110+
<include name="IDR_BRAVE_NEW_TAB_BACKGROUND13" file="../img/newtab/Phoyoserge_Corsica2.jpg" type="BINDATA" />
111+
<include name="IDR_BRAVE_NEW_TAB_BACKGROUND14" file="../img/newtab/Phoyoserge_DowntownGriffith.jpg" type="BINDATA" />
112+
<include name="IDR_BRAVE_NEW_TAB_BACKGROUND15" file="../img/newtab/Phoyoserge_ElmatadorBeach.jpg" type="BINDATA" />
113+
<include name="IDR_BRAVE_NEW_TAB_BACKGROUND16" file="../img/newtab/Phoyoserge_ParisConciergeri.jpg" type="BINDATA" />
114+
<include name="IDR_BRAVE_NEW_TAB_BACKGROUND17" file="../img/newtab/Phoyoserge_Theroofparis.jpg" type="BINDATA" />
115+
<include name="IDR_BRAVE_NEW_TAB_BACKGROUND18" file="../img/newtab/Phoyoserge_TheSeantParis.jpg" type="BINDATA" />
116+
<include name="IDR_BRAVE_NEW_TAB_BACKGROUND19" file="../img/newtab/Phoyoserge_VeniseSunset.jpg" type="BINDATA" />
117+
<include name="IDR_BRAVE_NEW_TAB_BACKGROUND20" file="../img/newtab/Phoyoserge_Yosemite.jpg" type="BINDATA" />
98118

99119
</includes>
100120
<messages fallback_to_english="true">

‎patches/extensions-browser-api-web_request-web_request_permissions.cc.patch

-15
This file was deleted.

0 commit comments

Comments
 (0)