Skip to content

Commit 9ae140a

Browse files
Prevent duplication of brave-sync metainfo in bookmarks on copying; fixes brave-browser#8325
1 parent 0b45d0f commit 9ae140a

File tree

3 files changed

+18
-0
lines changed

3 files changed

+18
-0
lines changed

browser/profiles/brave_bookmark_model_loaded_observer.cc

+5
Original file line numberDiff line numberDiff line change
@@ -41,5 +41,10 @@ void BraveBookmarkModelLoadedObserver::BookmarkModelLoaded(
4141
#endif
4242
profile_->GetPrefs()->SetBoolean(kOtherBookmarksMigrated, true);
4343
}
44+
45+
#if BUILDFLAG(ENABLE_BRAVE_SYNC)
46+
BraveProfileSyncServiceImpl::AddNonClonedBookmarkKeys(model);
47+
#endif
48+
4449
BookmarkModelLoadedObserver::BookmarkModelLoaded(model, ids_reassigned);
4550
}

components/brave_sync/brave_profile_sync_service_impl.cc

+11
Original file line numberDiff line numberDiff line change
@@ -523,6 +523,17 @@ void BraveProfileSyncServiceImpl::OnSyncReadyBookmarksModelLoaded() {
523523
}
524524
}
525525

526+
// static
527+
void BraveProfileSyncServiceImpl::AddNonClonedBookmarkKeys(
528+
BookmarkModel* model) {
529+
DCHECK(model);
530+
DCHECK(model->loaded());
531+
model->AddNonClonedKey("object_id");
532+
model->AddNonClonedKey("order");
533+
model->AddNonClonedKey("sync_timestamp");
534+
model->AddNonClonedKey("version");
535+
}
536+
526537
syncer::ModelTypeSet BraveProfileSyncServiceImpl::GetPreferredDataTypes()
527538
const {
528539
// Force DEVICE_INFO type to have nudge cycle each time to fetch

components/brave_sync/brave_profile_sync_service_impl.h

+2
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,8 @@ class BraveProfileSyncServiceImpl
175175
BraveSyncClient* GetBraveSyncClient() override;
176176
#endif
177177

178+
static void AddNonClonedBookmarkKeys(BookmarkModel* model);
179+
178180
bool IsBraveSyncEnabled() const override;
179181

180182
syncer::ModelTypeSet GetPreferredDataTypes() const override;

0 commit comments

Comments
 (0)