Moved element to system section

Author: spylogsster

browser/resources/settings/brave_help_tips_page/brave_help_tips_page.html

@@ -9,10 +9,6 @@
                           pref="{{prefs.brave.enable_window_closing_confirm}}"
                           label="$i18n{braveHelpTipsWarnBeforeClosingWindow}">
   </settings-toggle-button>
-  <settings-toggle-button class="cr-row"
-    pref="{{prefs.brave.enable_closing_last_tab}}"
-    label="$i18n{braveHelpTipsClosingLastTab}">
-  </settings-toggle-button>
 <if expr="is_macosx">
   <settings-toggle-button class="cr-row"
                           pref="{{prefs.browser.confirm_to_quit}}"

browser/resources/settings/brave_overrides/basic_page.js

@@ -54,6 +54,19 @@ function createSectionElement (sectionName, titleName, childName, childAttribute
   `
 }
 
+/**
+ * Creates a settings-toggle-button element and returns it.
+ * @param {string} pref - preference path to handle by toggle
+ * @param {string} label - label for the element
+ * @returns {Element}
+ */
+ function createToggleButtonElement (pref, label) {
+  return html`
+    <settings-toggle-button class="cr-row" pref="{{${pref}}}" label="${loadTimeData.getString(label)}">
+    </settings-toggle-button>
+  `
+}
+
 RegisterStyleOverride(
   'settings-basic-page',
   html`
@@ -240,6 +253,10 @@ RegisterPolymerTemplateModifications({
       // Move help tips after downloads
       const sectionDownloads = getSectionElement(advancedSubSectionsTemplate.content, 'downloads')
       sectionDownloads.insertAdjacentElement('afterend', sectionHelpTips)
+      // Add an element to Chromium's system section
+      const buttonElement = createToggleButtonElement("prefs.brave.enable_closing_last_tab", "braveHelpTipsClosingLastTab")
+      const sectionSystem = getSectionElement(advancedSubSectionsTemplate.content, 'system')
+      sectionSystem.appendChild(buttonElement)
     }
   }
 })