Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post channel specific GitHub release description via upload.py #1822

Closed
mbacchi opened this issue Oct 24, 2018 · 1 comment · Fixed by brave/brave-core#727
Closed

Post channel specific GitHub release description via upload.py #1822

mbacchi opened this issue Oct 24, 2018 · 1 comment · Fixed by brave/brave-core#727
Assignees
@mbacchi
Labels
QA/No
Milestone
0.55.x - Release ...

Comments

@mbacchi
Copy link
Contributor

mbacchi commented Oct 24, 2018

When update.py runs it posts a generic description with no channel specific information. We need to be able to differentiate between channels in this description. This is important for things such as the windows stub installer names etc.
mbacchi added a commit to brave/brave-core that referenced this issue Oct 24, 2018
@mbacchi
Create GitHub release with channel specific description
73e0e3b 
Fixes brave/brave-browser#1822
@mbacchi mbacchi added the QA/No label Oct 24, 2018
@mbacchi mbacchi mentioned this issue Oct 24, 2018
Merged
18 tasks
@mbacchi mbacchi self-assigned this Oct 25, 2018
@bbondy bbondy added this to the 0.55.x - Release Hotfix 2 milestone Oct 28, 2018
@bbondy
Copy link
Member

bbondy commented Oct 28, 2018

I did for this one, but pls make sure issues that are closed are in a milestone. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbacchi mbacchi

Labels
QA/No
Projects
None yet
Milestone
0.55.x - Release Hotfix 2 (Release Ch...
Development

Successfully merging a pull request may close this issue.

Create GitHub release with channel specific description brave/brave-core
3 participants
@bbondy @mbacchi @NejcZdovc