Skip to content
This repository was archived by the owner on May 10, 2024. It is now read-only.

[iOS] [Android] Update NTP Brave Stats to 'Trackers & Ads Blocked' #2528

Closed
karenkliu opened this issue May 8, 2020 · 5 comments
Closed
Assignees

Comments

@karenkliu
Copy link

karenkliu commented May 8, 2020

Description:

Update NTP Brave Stat text from 'Ads and Trackers Blocked' to 'Trackers & ads blocked'

Steps to Reproduce

  1. Open a new tab

Actual result:
Screen Shot 2020-05-08 at 11 25 43 AM

Expected result:
Screen Shot 2020-05-12 at 1 12 34 PM

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easily

Brave Version:
all versions

Device details:
n/a

Miscellaneous

This update is expected on all platforms.
Android brave/brave-browser#9693
Desktop brave/brave-browser#9692

@anthonypkeane
Copy link

Why not

Trackers & Ads Blocked @karenkliu

@karenkliu
Copy link
Author

@anthonypkeane We are moving towards Sentence case everywhere (labels, button text, titles, etc.) except for things that are already Proper Nouns. So all three of the Brave Stats numbers should use sentence case because none of them contain proper nouns.

@anthonypkeane
Copy link

That is not consistent with iOS

@karenkliu
Copy link
Author

Apple tends to use Title Case for everything, including menu items, but the NTP is our own UI. I don't think we need to conform our capitalization in our own UI to their system text. But LMK your final call on this and I'll update the screens for this issue.

@kylehickinson
Copy link
Collaborator

Going to close this in favour of #2932 which includes some other copy changes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants