Skip to content

Commit e544c30

Browse files
src: remove old code
The Socket writable only change was added and implemented in the constructor around 5885f46, but this was never removed. The libev counter issue is no longer prudent; the test remains in test/sequential/test-regress-GH-1726.
1 parent ff79449 commit e544c30

File tree

1 file changed

+0
-19
lines changed

1 file changed

+0
-19
lines changed

src/node.js

-19
Original file line numberDiff line numberDiff line change
@@ -578,12 +578,6 @@
578578
var tty = NativeModule.require('tty');
579579
stream = new tty.WriteStream(fd);
580580
stream._type = 'tty';
581-
582-
// Hack to have stream not keep the event loop alive.
583-
// See https://github.com/joyent/node/issues/1726
584-
if (stream._handle && stream._handle.unref) {
585-
stream._handle.unref();
586-
}
587581
break;
588582

589583
case 'FILE':
@@ -600,20 +594,7 @@
600594
readable: false,
601595
writable: true
602596
});
603-
604-
// FIXME Should probably have an option in net.Socket to create a
605-
// stream from an existing fd which is writable only. But for now
606-
// we'll just add this hack and set the `readable` member to false.
607-
// Test: ./node test/fixtures/echo.js < /etc/passwd
608-
stream.readable = false;
609-
stream.read = null;
610597
stream._type = 'pipe';
611-
612-
// FIXME Hack to have stream not keep the event loop alive.
613-
// See https://github.com/joyent/node/issues/1726
614-
if (stream._handle && stream._handle.unref) {
615-
stream._handle.unref();
616-
}
617598
break;
618599

619600
default:

0 commit comments

Comments
 (0)