External storage exists but not writable (#2641)

anpez · sjudd · commit 5580e517d05d · 2017-11-24T10:34:51.000-08:00
* Some phones (like Huawei P9) are detecting external storage as available, but it's not writable.
diff --git a/library/src/main/java/com/bumptech/glide/load/engine/cache/ExternalPreferredCacheDiskCacheFactory.java b/library/src/main/java/com/bumptech/glide/load/engine/cache/ExternalPreferredCacheDiskCacheFactory.java
@@ -52,7 +52,7 @@ public File getCacheDirectory() {
         File cacheDirectory = context.getExternalCacheDir();
 
         // Shared storage is not available.
-        if (cacheDirectory == null) {
+        if ((cacheDirectory == null) || (!cacheDirectory.canWrite())) {
           return internalCacheDirectory;
         }
         if (diskCacheName != null) {

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ public File getCacheDirectory() {`
`52`	`52`	`File cacheDirectory = context.getExternalCacheDir();`
`53`	`53`
`54`	`54`	`// Shared storage is not available.`
`55`		`- if (cacheDirectory == null) {`
	`55`	`+ if ((cacheDirectory == null) \|\| (!cacheDirectory.canWrite())) {`
`56`	`56`	`return internalCacheDirectory;`
`57`	`57`	`}`
`58`	`58`	`if (diskCacheName != null) {`