crash because of wrong executor being created (#2508)

stephanenicolas · sjudd · commit e6e2aef946b9 · 2017-10-23T18:00:49.000-07:00
Glide v4.2.x crashes because of wrong executor when using a custom UncaughtExceptionPolicy.
diff --git a/library/src/main/java/com/bumptech/glide/load/engine/executor/GlideExecutor.java b/library/src/main/java/com/bumptech/glide/load/engine/executor/GlideExecutor.java
@@ -140,7 +140,7 @@ public static GlideExecutor newSourceExecutor() {
    */
   public static GlideExecutor newSourceExecutor(
           UncaughtThrowableStrategy uncaughtThrowableStrategy) {
-    return newDiskCacheExecutor(DEFAULT_DISK_CACHE_EXECUTOR_THREADS,
+    return newSourceExecutor(DEFAULT_DISK_CACHE_EXECUTOR_THREADS,
                                 DEFAULT_DISK_CACHE_EXECUTOR_NAME, uncaughtThrowableStrategy);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ public static GlideExecutor newSourceExecutor() {`
`140`	`140`	`*/`
`141`	`141`	`public static GlideExecutor newSourceExecutor(`
`142`	`142`	`UncaughtThrowableStrategy uncaughtThrowableStrategy) {`
`143`		`- return newDiskCacheExecutor(DEFAULT_DISK_CACHE_EXECUTOR_THREADS,`
	`143`	`+ return newSourceExecutor(DEFAULT_DISK_CACHE_EXECUTOR_THREADS,`
`144`	`144`	`DEFAULT_DISK_CACHE_EXECUTOR_NAME, uncaughtThrowableStrategy);`
`145`	`145`	`}`
`146`	`146`