Make PMD depend on compiled .class files (#2778)

* Revert "Fix spurious PMD warnings when building with —-profile."

This reverts commit cc4bb16.

* Make PMD depend on compiled .class files so type resolution can do its job.

* Make FindBugs depend on compiled .class files via specific task and dynamic value

Author: TWiStErRob

library/build.gradle

@@ -67,12 +67,12 @@ afterEvaluate {
     }
 
     tasks.create('findbugs', FindBugs) {
-        dependsOn tasks.assembleDebug
+        dependsOn tasks.compileDebugJavaWithJavac
 
         description 'Run findbugs'
         group 'verification'
 
-        classes = fileTree("${project.buildDir}/intermediates/classes/debug/")
+        classes = fileTree(tasks.compileDebugJavaWithJavac.destinationDir)
         source android.sourceSets.main.java.srcDirs
         classpath = files()
         doFirst {
@@ -97,6 +97,7 @@ afterEvaluate {
     }
 
     tasks.create('pmd', Pmd) {
+        dependsOn tasks.compileDebugJavaWithJavac
         targetJdk = TargetJdk.VERSION_1_7
 
         description 'Run pmd'
@@ -108,7 +109,7 @@ afterEvaluate {
         ruleSetFiles = files('pmd-ruleset.xml')
         source android.sourceSets.main.java.srcDirs
         classpath = files()
-        classpath += files("${project.buildDir}/intermediates/classes/debug/")
+        classpath += files(tasks.compileDebugJavaWithJavac.destinationDir)
         doFirst {
             classpath += classPathForQuality()
         }

library/src/main/java/com/bumptech/glide/load/engine/Engine.java

@@ -235,14 +235,10 @@ public <R> LoadStatus load(
     return new LoadStatus(cb, engineJob);
   }
 
-  // TODO(#2776): Remove this suppression.
-  @SuppressWarnings("PMD.UnusedPrivateMethod")
   private static void logWithTimeAndKey(String log, long startTime, Key key) {
     Log.v(TAG, log + " in " + LogTime.getElapsedMillis(startTime) + "ms, key: " + key);
   }
 
-  // TODO(#2776): Remove this suppression.
-  @SuppressWarnings("PMD.UnusedPrivateMethod")
   @Nullable
   private EngineResource<?> loadFromActiveResources(Key key, boolean isMemoryCacheable) {
     if (!isMemoryCacheable) {
@@ -256,8 +252,6 @@ private EngineResource<?> loadFromActiveResources(Key key, boolean isMemoryCache
     return active;
   }
 
-  // TODO(#2776): Remove this suppression.
-  @SuppressWarnings("PMD.UnusedPrivateMethod")
   private EngineResource<?> loadFromCache(Key key, boolean isMemoryCacheable) {
     if (!isMemoryCacheable) {
       return null;