Skip to content

Commit f438c12

Browse files
committed
remove adding default tenant ids to job worker configuration
1 parent a4edae4 commit f438c12

File tree

3 files changed

+3
-30
lines changed

3 files changed

+3
-30
lines changed

spring-boot-starter-camunda/src/main/java/io/camunda/zeebe/spring/client/properties/PropertyBasedZeebeWorkerValueCustomizer.java

-15
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ public PropertyBasedZeebeWorkerValueCustomizer(
3939
public void customize(ZeebeWorkerValue zeebeWorker) {
4040
applyDefaultWorkerName(zeebeWorker);
4141
applyDefaultJobWorkerType(zeebeWorker);
42-
applyTenantIds(zeebeWorker);
4342
applyFetchVariables(zeebeWorker);
4443
applyOverrides(zeebeWorker);
4544
}
@@ -100,20 +99,6 @@ private void applyOverrides(ZeebeWorkerValue zeebeWorker) {
10099
}
101100
}
102101

103-
private void applyTenantIds(ZeebeWorkerValue zeebeWorker) {
104-
List<String> defaultJobWorkerTenantIds =
105-
zeebeClientConfigurationProperties.getDefaultJobWorkerTenantIds();
106-
if (defaultJobWorkerTenantIds != null
107-
&& !defaultJobWorkerTenantIds.isEmpty()
108-
&& (zeebeWorker.getTenantIds() == null || zeebeWorker.getTenantIds().isEmpty())) {
109-
LOG.debug(
110-
"Worker '{}': Setting default tenant ids to {}",
111-
zeebeWorker.getName(),
112-
defaultJobWorkerTenantIds);
113-
zeebeWorker.setTenantIds(defaultJobWorkerTenantIds);
114-
}
115-
}
116-
117102
private void applyDefaultWorkerName(ZeebeWorkerValue zeebeWorker) {
118103
String defaultJobWorkerName = zeebeClientConfigurationProperties.getDefaultJobWorkerName();
119104
if (isBlank(zeebeWorker.getName())) {

spring-boot-starter-camunda/src/test/java/io/camunda/zeebe/spring/client/properties/PropertyBasedZeebeWorkerValueCustomizerTest.java

-15
Original file line numberDiff line numberDiff line change
@@ -138,21 +138,6 @@ void shouldNotSetNameOfVariablesAsTypeAnnotatedField() {
138138
assertThat(zeebeWorkerValue.getFetchVariables()).doesNotContain("var2");
139139
}
140140

141-
@Test
142-
void shouldSetDefaultTenantIds() {
143-
// given
144-
ZeebeClientConfigurationProperties properties = properties();
145-
PropertyBasedZeebeWorkerValueCustomizer customizer =
146-
new PropertyBasedZeebeWorkerValueCustomizer(properties);
147-
ZeebeWorkerValue zeebeWorkerValue = new ZeebeWorkerValue();
148-
zeebeWorkerValue.setMethodInfo(methodInfo(this, "testBean", "sampleWorker"));
149-
// when
150-
customizer.customize(zeebeWorkerValue);
151-
// then
152-
assertThat(zeebeWorkerValue.getTenantIds())
153-
.containsOnly(ZeebeClientConfigurationProperties.DEFAULT.getDefaultTenantId());
154-
}
155-
156141
@Test
157142
void shouldApplyOverrides() {
158143
// given

spring-client-zeebe/src/main/java/io/camunda/zeebe/spring/client/jobhandling/JobWorkerManager.java

+3
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,9 @@ public JobWorker openWorker(
7474
&& zeebeWorkerValue.getFetchVariables().length > 0) {
7575
builder.fetchVariables(zeebeWorkerValue.getFetchVariables());
7676
}
77+
if (zeebeWorkerValue.getTenantIds() != null && !zeebeWorkerValue.getTenantIds().isEmpty()) {
78+
builder.tenantIds(zeebeWorkerValue.getTenantIds());
79+
}
7780

7881
JobWorker jobWorker = builder.open();
7982
openedWorkers.add(jobWorker);

0 commit comments

Comments
 (0)