fix(admin): fix members endpoint #207
Closed
+14
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removing prefixing of URL, as it breaks member endpoint calls. Updated all cluster endpoint calls to have the 'clusters' prefixed to their urls.
Update AdminApiClient.ts
|
Hi @dfulgham thanks for this PR. A couple of things:
The instructions for contributions are detailed in https://github.com/camunda/camunda-8-js-sdk/blob/main/CONTRIBUTING.md I can squash and merge the PR with a new commit message, so don't worry about changing the commit messages. You should be able to create a new branch from |
dfulgham
added a commit
to dfulgham/camunda-8-js-sdk
that referenced
this pull request
Jul 8, 2024
removed 'clusters' from prefixUrl and updated clusters endpoint urls to include 'clusters/...'
dfulgham
changed the title
dfulgham
changed the title
dfulgham
added a commit
to dfulgham/camunda-8-js-sdk
that referenced
this pull request
Jul 8, 2024
fixed debug output for prefixUrl
dfulgham
changed the title
jwulf
pushed a commit
that referenced
this pull request
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing prefix 'clusters' from the URL as it breaks calls to /members endpoints.
Updated all clusters methods to prefix them with 'clusters/'