Skip to content

Commit 0452d7c

Browse files
fix: [#1072] Handle nested square brackets and parentheses inside pseudo-class arguments (#1752)
Co-authored-by: David Ortner <david@ortner.se>
1 parent 6f7057d commit 0452d7c

File tree

2 files changed

+16
-1
lines changed

2 files changed

+16
-1
lines changed

packages/happy-dom/src/query-selector/SelectorParser.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import ISelectorPseudo from './ISelectorPseudo.js';
2525
* Group 17: Combinator.
2626
*/
2727
const SELECTOR_REGEXP =
28-
/(\*)|([a-zA-Z0-9-]+)|#((?:[a-zA-Z0-9-_]|\\.)+)|\.((?:[a-zA-Z0-9-_]|\\.)+)|\[([a-zA-Z0-9-_\\:]+)\]|\[([a-zA-Z0-9-_\\:]+)\s*([~|^$*]{0,1})\s*=\s*["']{1}([^"']*)["']{1}\s*(s|i){0,1}\]|\[([a-zA-Z0-9-_]+)\s*([~|^$*]{0,1})\s*=\s*([^\]]*)\]|:([a-zA-Z-]+)\s*\(([^)]+)\){0,1}|:([a-zA-Z-]+)|::([a-zA-Z-]+)|([\s,+>~]*)/gm;
28+
/(\*)|([a-zA-Z0-9-]+)|#((?:[a-zA-Z0-9-_]|\\.)+)|\.((?:[a-zA-Z0-9-_]|\\.)+)|\[([a-zA-Z0-9-_\\:]+)\]|\[([a-zA-Z0-9-_\\:]+)\s*([~|^$*]{0,1})\s*=\s*["']{1}([^"']*)["']{1}\s*(s|i){0,1}\]|\[([a-zA-Z0-9-_]+)\s*([~|^$*]{0,1})\s*=\s*([^\]]*)\]|:([a-zA-Z-]+)\s*\(((?:[^()]|\[[^\]]*\]|\([^()]*\))*)\){0,1}|:([a-zA-Z-]+)|::([a-zA-Z-]+)|([\s,+>~]*)/gm;
2929

3030
/**
3131
* Escaped Character RegExp.

packages/happy-dom/test/query-selector/QuerySelector.test.ts

+15
Original file line numberDiff line numberDiff line change
@@ -1265,6 +1265,21 @@ describe('QuerySelector', () => {
12651265
expect(subsequentSiblings3[0].textContent).toBe('a2');
12661266
expect(subsequentSiblings3[1].textContent).toBe('a3');
12671267
});
1268+
1269+
it('Returns all elements for attribute selector with round brackets within', () => {
1270+
const div = document.createElement('div');
1271+
1272+
div.innerHTML = `
1273+
<span>loremipsum</span>
1274+
<a href="/123">normal link</a>
1275+
<a href="javascript:void(0)">void</a>
1276+
`;
1277+
1278+
const voidLinks = div.querySelectorAll('a[href="javascript:void(0)"]');
1279+
expect(voidLinks.length).toBe(1);
1280+
const normalLinks = div.querySelectorAll('a[href]:not([href="javascript:void(0)"])');
1281+
expect(normalLinks.length).toBe(1);
1282+
});
12681283
});
12691284

12701285
describe('querySelector()', () => {

0 commit comments

Comments
 (0)