Skip to content

Commit 9acbaf9

Browse files
committed
remove unnessesary docker container id truncation
Signed-off-by: hengyoush <hengyoush1@163.com>
1 parent 6bdd1d5 commit 9acbaf9

File tree

3 files changed

+2
-18
lines changed

3 files changed

+2
-18
lines changed

exec/container/controller.go

+1-8
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ import (
2323
"strconv"
2424
"strings"
2525

26-
"github.com/chaosblade-io/chaosblade-exec-cri/exec/container"
2726
"github.com/chaosblade-io/chaosblade-spec-go/util"
2827
"github.com/sirupsen/logrus"
2928
v1 "k8s.io/api/core/v1"
@@ -145,9 +144,6 @@ func getMatchedContainerMetaList(pods []v1.Pod, containerIdsValue, containerName
145144
containerStatusErr = errors.New("containerId is empty")
146145
} else {
147146
containerRuntime, containerId = model.TruncateContainerObjectMetaUid(containerStatus.ContainerID)
148-
if containerRuntime == container.DockerRuntime {
149-
// containerId = containerId[:12]
150-
}
151147
}
152148
if containerStatus.State.Running == nil {
153149
if containerStatusErr != nil {
@@ -161,7 +157,7 @@ func getMatchedContainerMetaList(pods []v1.Pod, containerIdsValue, containerName
161157
if expectedContainerId == "" {
162158
continue
163159
}
164-
if strings.HasPrefix(containerId /*k8s中获取的*/, expectedContainerId /*用户输入的,可能为全限定*/) {
160+
if strings.HasPrefix(containerId, expectedContainerId) {
165161
if containerStatusErr != nil {
166162
return containerObjectMetaList, spec.ResponseFailWithFlags(spec.ParameterInvalid,
167163
model.ContainerIdsFlag.Name, expectedContainerId,
@@ -229,9 +225,6 @@ func getMatchedContainerMetaList(pods []v1.Pod, containerIdsValue, containerName
229225
fmt.Sprintf("container: %s %s", containerStatuses[idx].Name, containerStatusErr.Error()))
230226
}
231227
containerRuntime, containerId := model.TruncateContainerObjectMetaUid(containerStatuses[idx].ContainerID)
232-
if containerRuntime == container.DockerRuntime {
233-
// containerId = containerId[:12]
234-
}
235228
containerObjectMetaList = append(containerObjectMetaList, model.ContainerObjectMeta{
236229
ContainerRuntime: containerRuntime,
237230
ContainerId: containerId,

exec/model/executor_copy.go

+1-5
Original file line numberDiff line numberDiff line change
@@ -412,11 +412,7 @@ func getNewContainerIdByPod(podName, podNamespace, containerName, experimentId s
412412
for _, containerStatus := range containerStatuses {
413413
if containerName == containerStatus.Name {
414414
_, containerLongId := TruncateContainerObjectMetaUid(containerStatus.ContainerID)
415-
if len(containerLongId) > 12 {
416-
// return containerLongId[:12], nil
417-
return containerLongId, nil
418-
}
419-
return "", fmt.Errorf("the container %s id is illegal", containerLongId)
415+
return containerLongId, nil
420416
}
421417
}
422418
return "", fmt.Errorf("cannot find the %s container in %s pod", containerName, podName)

exec/pod/controller.go

-5
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@ package pod
1919
import (
2020
"context"
2121

22-
"github.com/chaosblade-io/chaosblade-exec-cri/exec/container"
23-
2422
"github.com/sirupsen/logrus"
2523
v1 "k8s.io/api/core/v1"
2624

@@ -94,9 +92,6 @@ func getContainerMatchedList(experimentId string, pods []v1.Pod) model.Container
9492
containerObjectMetaList := model.ContainerMatchedList{}
9593
for _, p := range pods {
9694
containerId, containerName, runtime, err := model.GetOneAvailableContainerIdFromPod(p)
97-
if runtime == container.DockerRuntime {
98-
// containerId = containerId[:12]
99-
}
10095

10196
if err != nil {
10297
logrus.WithField("experiment", experimentId).WithField("pod", p.Name).

0 commit comments

Comments
 (0)