Skip to content

Commit 5e1752a

Browse files
committed
avoid VS17 compiler warning
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\algorithm(1007): warning C4244: '=': conversion from 'int' to 'wchar_t', possible loss of data (compiling source file ..\..\..\Common\Ccpp\Common.cpp) [C:\projects\npp-hexedit\HexEditor\projects\2003\HexEditor.vcxproj] C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.12.25827\include\algorithm(1020): note: see reference to function template instantiation '_OutIt std::_Transform_no_deprecate<_InIt,_OutIt,int(__cdecl *)(int)>(_InIt,_InIt,_OutIt,_Fn)' being compiled with [ _OutIt=std::_String_iterator<std::_String_val<std::_Simple_types<wchar_t>>>, _InIt=std::_String_iterator<std::_String_val<std::_Simple_types<wchar_t>>>, _Fn=int (__cdecl *)(int) ] (compiling source file ..\..\..\Common\Ccpp\Common.cpp) ..\..\..\Common\Ccpp\Common.cpp(769): note: see reference to function template instantiation '_OutIt std::transform<std::_String_iterator<std::_String_val<std::_Simple_types<_Ty>>>,std::_String_iterator<std::_String_val<std::_Simple_types<_Ty>>>,int(__cdecl *)(int)>(_InIt,_InIt,_OutIt,_Fn)' being compiled with [ _OutIt=std::_String_iterator<std::_String_val<std::_Simple_types<wchar_t>>>, _Ty=wchar_t, _InIt=std::_String_iterator<std::_String_val<std::_Simple_types<wchar_t>>>, _Fn=int (__cdecl *)(int) ]
1 parent 3aae0fb commit 5e1752a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Common/Ccpp/Common.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -766,7 +766,7 @@ COLORREF getCtrlBgColor(HWND hWnd)
766766

767767
generic_string stringToUpper(generic_string strToConvert)
768768
{
769-
std::transform(strToConvert.begin(), strToConvert.end(), strToConvert.begin(), ::toupper);
769+
std::transform(strToConvert.begin(), strToConvert.end(), strToConvert.begin(), [](TCHAR ch) { return static_cast<TCHAR>(_totupper(ch)); });
770770
return strToConvert;
771771
}
772772

0 commit comments

Comments
 (0)