Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing last column marks first column as non-header #1986

Closed
pomek opened this issue Aug 22, 2019 · 3 comments
Closed

Removing last column marks first column as non-header #1986

pomek opened this issue Aug 22, 2019 · 3 comments
Labels
resolution:duplicate This issue is a duplicate of another issue and was merged into it. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@pomek
Copy link
Member

pomek commented Aug 22, 2019

Is this a bug report or feature request? (choose one)

🐞 Bug report

💻 Version of CKEditor

Master

📋 Steps to reproduce

  1. Paste the table below somewhere in the editor
A B C
A X 0-0 0-0
B 0-0 X 0-0
C 0-0 0-0 X
  1. Mark first row and first column as Header Row/Column
  2. Select first row, last column.
  3. Remove the entire column.

✅ Expected result

The first column shouldn't be touched.

image

❎ Actual result

The first column isn't marked as Header column.

image

@pomek pomek added the type:bug This issue reports a buggy (incorrect) behavior. label Aug 22, 2019
@pomek
Copy link
Member Author

pomek commented Aug 22, 2019

If two columns are headers, the first one stays as a header, the second one loses the attribute when removing the last column.

@jodator
Copy link
Contributor

jodator commented Aug 22, 2019

Probably the same case as here: https://github.com/ckeditor/ckeditor5-table/issues/203. So those should be fixed together.

@scofalik
Copy link
Contributor

@scofalik scofalik added the resolution:duplicate This issue is a duplicate of another issue and was merged into it. label Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution:duplicate This issue is a duplicate of another issue and was merged into it. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

4 participants