Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read_start bug in luv #11

Open
soumith opened this issue Feb 2, 2014 · 3 comments
Open

read_start bug in luv #11

soumith opened this issue Feb 2, 2014 · 3 comments

Comments

@soumith
Copy link
Contributor

soumith commented Feb 2, 2014

Relevant to async. Memory still leaks.
I am just calling uv.read_stop explicitly (in handle.lua), once reading has started, before shutting down.

luvit/luv#22

It's a hacky way, but it solves leaking. If you want I can send in a pull request.

@clementfarabet
Copy link
Owner

So inserting uv.read_stop() there solves the problem right?

@soumith
Copy link
Contributor Author

soumith commented Feb 2, 2014

yes, pretty much wherever uv.close is called if you add
if h.reading then uv.read_stop(h) end

@soumith
Copy link
Contributor Author

soumith commented Feb 2, 2014

soumith@0cbe855

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants