Skip to content

Commit d86e845

Browse files
Pbd/release-fixups (#8259)
* tweak changeset * Revert "Use print in Python console.log test (#8252)" This reverts commit 71eea4f. * Revert "Adds Python `wrangler dev` test to verify `print` works. (#8195)" This reverts commit 1ad53c5. * chore: add env vars needed for e2e testing to turbo.json In strict mode turbo will block these env vars.
1 parent 6dd1e23 commit d86e845

File tree

3 files changed

+4
-44
lines changed

3 files changed

+4
-44
lines changed

.changeset/beige-crews-wash.md

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
2-
"@cloudflare/workers-shared": minor
3-
"miniflare": minor
4-
"wrangler": minor
2+
"@cloudflare/workers-shared": patch
3+
"miniflare": patch
4+
"wrangler": patch
55
---
66

77
feat: Omits Content-Type header for files of an unknown extension in Workers Assets

packages/wrangler/e2e/dev.test.ts

-41
Original file line numberDiff line numberDiff line change
@@ -485,47 +485,6 @@ describe.each([{ cmd: "wrangler dev" }])(
485485

486486
expect(text).toBe("py hello world 5");
487487
});
488-
489-
it(`can print during ${cmd}`, async () => {
490-
const helper = new WranglerE2ETestHelper();
491-
await helper.seed({
492-
"wrangler.toml": dedent`
493-
name = "${workerName}"
494-
main = "index.py"
495-
compatibility_date = "2023-01-01"
496-
compatibility_flags = ["python_workers"]
497-
`,
498-
"arithmetic.py": dedent`
499-
def mul(a,b):
500-
return a*b`,
501-
"index.py": dedent`
502-
from arithmetic import mul
503-
504-
from js import Response, console
505-
def on_fetch(request):
506-
console.log(f"hello {mul(2,3)}")
507-
print(f"foobar {mul(4,3)}")
508-
console.log(f"end")
509-
return Response.new(f"py hello world {mul(2,3)}")`,
510-
"package.json": dedent`
511-
{
512-
"name": "worker",
513-
"version": "0.0.0",
514-
"private": true
515-
}
516-
`,
517-
});
518-
const worker = helper.runLongLived(cmd);
519-
520-
const { url } = await worker.waitForReady();
521-
522-
await expect(fetchText(url)).resolves.toBe("py hello world 6");
523-
524-
await worker.readUntil(/end/);
525-
526-
const allOutput = await worker.output;
527-
expect(allOutput).contain("hello 6\nfoobar 12\nend");
528-
});
529488
}
530489
);
531490

turbo.json

+1
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@
4343
"outputLogs": "new-only"
4444
},
4545
"test:e2e": {
46+
"env": ["WRANGLER", "CLOUDFLARE_ACCOUNT_ID", "CLOUDFLARE_API_TOKEN"],
4647
"dependsOn": ["build"],
4748
"outputLogs": "new-only"
4849
},

0 commit comments

Comments
 (0)