From fc810e8c72d4f2d7ee9dab21ff04e423c6032086 Mon Sep 17 00:00:00 2001 From: Mo Kweon Date: Thu, 24 Jun 2021 23:32:23 -0700 Subject: [PATCH 1/2] feat: use accentColor for ExpandableText icon --- client/lib/widgets/components/expandable_text.dart | 2 ++ 1 file changed, 2 insertions(+) diff --git a/client/lib/widgets/components/expandable_text.dart b/client/lib/widgets/components/expandable_text.dart index 533feb94..5c9afcaf 100644 --- a/client/lib/widgets/components/expandable_text.dart +++ b/client/lib/widgets/components/expandable_text.dart @@ -34,6 +34,7 @@ class _ExpandableTextState extends State { IconButton( iconSize: iconSize, onPressed: onPressed, + color: Theme.of(context).accentColor, icon: const Icon(Icons.keyboard_arrow_up)), ], ), @@ -55,6 +56,7 @@ class _ExpandableTextState extends State { child: IconButton( iconSize: iconSize, onPressed: onPressed, + color: Theme.of(context).accentColor, icon: const Icon(Icons.keyboard_arrow_down))) ]); } From 29641915838435734cc527bba09172a7a1f215b9 Mon Sep 17 00:00:00 2001 From: Mo Kweon Date: Fri, 25 Jun 2021 01:52:17 -0700 Subject: [PATCH 2/2] feat: use ListView for Repositories (#132) --- client/lib/widgets/detail/repository.dart | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/client/lib/widgets/detail/repository.dart b/client/lib/widgets/detail/repository.dart index 6197baf3..c87ed616 100644 --- a/client/lib/widgets/detail/repository.dart +++ b/client/lib/widgets/detail/repository.dart @@ -22,14 +22,9 @@ class RepositoryWidget extends StatelessWidget { "Repositories", style: Theme.of(context).textTheme.headline1, )), - // ignore: sized_box_for_whitespace - Container( - height: 150, - child: GridView.builder( - gridDelegate: const SliverGridDelegateWithMaxCrossAxisExtent( - maxCrossAxisExtent: 200, - childAspectRatio: 6.5 / 2, - ), + SizedBox( + height: 400, + child: ListView.builder( itemCount: visibleRepositories.length, itemBuilder: (BuildContext context, int index) => getItemCard(context, visibleRepositories[index]))) @@ -76,6 +71,11 @@ class RepositoryWidget extends StatelessWidget { title: Text( extractRepoNameFromURL(repo.url), ), + subtitle: Text( + repo.description, + maxLines: 1, + overflow: TextOverflow.ellipsis, + ), )), ); }