Skip to content

Commit ff4eab6

Browse files
dbastjaimergp
andauthoredMar 26, 2025··
Remove isort+black leftovers, re-enable flake8 + isort rules (#318)
* Remove isort+black leftovers, re-enable flake8 + isort rules * Update 315-pre-commit --------- Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
1 parent bd03639 commit ff4eab6

File tree

3 files changed

+12
-20
lines changed

3 files changed

+12
-20
lines changed
 

‎menuinst/platforms/osx.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -326,9 +326,9 @@ def _needs_appkit_launcher(self) -> bool:
326326
If that key is absent or null, we assume the app has its own listener.
327327
328328
See:
329-
- https://developer.apple.com/library/archive/documentation/Carbon/Conceptual/LaunchServicesConcepts/LSCConcepts/LSCConcepts.html # noqa
329+
- https://developer.apple.com/library/archive/documentation/Carbon/Conceptual/LaunchServicesConcepts/LSCConcepts/LSCConcepts.html
330330
- The source code at /src/appkit-launcher in this repository
331-
"""
331+
""" # noqa
332332
return bool(self.metadata.get("event_handler"))
333333

334334

‎news/315-pre-commit

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,5 @@
1616

1717
### Other
1818

19-
* Use `ruff` for linting and formatting. (#315)
19+
* Use `ruff` for linting and formatting. (#315, #318)
2020
* Check and pretty-format JSON files. (#315)

‎pyproject.toml

+9-17
Original file line numberDiff line numberDiff line change
@@ -26,23 +26,6 @@ where = ["."]
2626
include = ["menuinst*"]
2727
namespaces = true
2828

29-
[tool.black]
30-
line-length = 99
31-
target-version = ['py38', 'py39', 'py310', 'py311']
32-
include = '\.pyi?$'
33-
exclude = '''
34-
^/(
35-
(
36-
menuinst/_legacy
37-
| tests/_legacy
38-
)/
39-
)
40-
'''
41-
42-
[tool.isort]
43-
profile = "black"
44-
line_length = 99
45-
4629
[tool.pyright]
4730
pythonPlatform = "All"
4831

@@ -52,6 +35,15 @@ exclude = [
5235
"_schema.py"
5336
]
5437

38+
[tool.ruff.lint]
39+
# see https://docs.astral.sh/ruff/rules/
40+
select = [
41+
"E", # pycodestyle errors (part of flake8)
42+
"F", # pyflakes (part of flake8)
43+
"I", # isort
44+
"W", # pycodestyle warnings (part of flake8)
45+
]
46+
5547
[tool.vendoring]
5648
destination = "menuinst/_vendor/"
5749
namespace = "menuinst._vendor"

0 commit comments

Comments
 (0)
Please sign in to comment.