Resources import problems — post 2024.04

[andyp-uk]

Replicated on 2024.10, presumably introduced by JQuery updates in 2024.04:

First problem

1. Go to Resources > Admin > Import Configuration.
2. Click Add import configuration.
3. Observe modal window is blank. Press Esc to back out.
4. In the Network tab of devtools, observe Error 500 on GET https://devtest1-erm.bc.sirsidynix.net/resources/ajax_forms.php?action=getAdminImportConfigUpdateForm&updateID=. Response data seems to truncate after Alias Sets heading.

Second problem

1. Go to Resources > File Import.
2. Upload a file.
3. Observe the page stops rendering after Alias Sets heading.
4. Select a configuration where prompted, if you have an option listed.
5. The page seems to render properly. But where is the button to finalise the import?

[stephanieleary]

It's PHP 8, not jQuery. count() now throws an error if its argument isn't iterable. We have about 200 places where we check whether count($SOMETHING) > 0 without first checking that $SOMETHING is an array, which was fine before but now brings PHP to a screeching halt.

I'm going to fix this throughout in the accessibility branch.

[stephanieleary]

Here is the regex pattern I've used:
search: if \(count\((\$.*) > 0\)
replace: if (is_array($1 && count($1 > 0)