Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple StoreValue Data-Fields in Object #2746

Closed
la-lisa opened this issue Nov 5, 2024 · 6 comments
Closed

Multiple StoreValue Data-Fields in Object #2746

la-lisa opened this issue Nov 5, 2024 · 6 comments
Assignees
Milestone

Comments

@la-lisa
Copy link

la-lisa commented Nov 5, 2024

Q A
Bug report? yes
Feature request? no
BC Break report? yes
RFC? yes/no

Steps to reproduce:
We added multiple storeValue fields in our product class, one for overall price and one for different shipping prices per product.
Bildschirmfoto 2024-11-05 um 11 19 48

When filling in prices for both those fields then, there occurs a unique constraint violation in the product_store_values table when saving, because the fields reference is not saved in the table (only productid and store). If filling in only one of the fields, saving is possible but the values are the same in both data fields then.
Bildschirmfoto 2024-11-05 um 12 28 10

Is it not possible anymore to have multiple coreShopStoreValues typed fields in one object? In previous versions it was possible to have multiple.

@dpfaffenbauer
Copy link
Member

@la-lisa it never was meant to be used multiple times, we could try to enable that though.

@dpfaffenbauer
Copy link
Member

what version you are having issues with?

@la-lisa
Copy link
Author

la-lisa commented Nov 5, 2024

what version you are having issues with?

Newest Version. 4.0.11

@la-lisa
Copy link
Author

la-lisa commented Nov 5, 2024

@la-lisa it never was meant to be used multiple times, we could try to enable that though.

Okay, good to know. A note in the docs or a validation on class definition save would be nice then. Because it can be added multiple times but has weird effects than.
In old versions it was possible although... We have a coreshop 2 where this works. Maybe with the product_store_prices table then or something like this.

@dpfaffenbauer
Copy link
Member

@la-lisa I actually like the idea of having it multiple times. I see what I can do

@dpfaffenbauer
Copy link
Member

@la-lisa #2747

@dpfaffenbauer dpfaffenbauer self-assigned this Nov 6, 2024
@dpfaffenbauer dpfaffenbauer added this to the 4.0.12 milestone Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants