This repository was archived by the owner on Jul 27, 2022. It is now read-only.
Problem (Fix #1091): Inactivated validator can still appear in block proposer #1092
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in block proposer Solution: - Check validator not active when record reward stats
yihuang
requested review from
calvinaco,
devashishdxt and
tomtau
as code owners
tomtau
approved these changes
Feb 18, 2020
There was a problem hiding this comment.
not that happy about validator_voting_power being used directly (I left it public for later encapsulation), but I guess ok for a quick fix for now, as implementation will likely change after crypto-org-chain/chain-docs#79
|
bors r+ |
Codecov Report
@@ Coverage Diff @@
## master #1092 +/- ##
=========================================
- Coverage 66.41% 66.4% -0.01%
=========================================
Files 145 145
Lines 18792 18793 +1
=========================================
- Hits 12480 12479 -1
- Misses 6312 6314 +2
|
bors bot
added a commit
that referenced
this pull request
Feb 18, 2020
1092: Problem (Fix #1091): Inactivated validator can still appear in block proposer r=tomtau a=yihuang Solution: - Check validator not active when record reward stats 1094: Problem (Fix #1093): Mock mode in master branch not buildable r=tomtau a=yihuang Solution: - Make it build again Co-authored-by: yihuang <huang@crypto.com>
Build failed (retrying...) |
Build failed |
|
bors retry |
Build succeeded |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: