Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touchpad Gestures Messed Up #951

Open
mreitenb opened this issue Dec 23, 2020 · 12 comments
Open

Touchpad Gestures Messed Up #951

mreitenb opened this issue Dec 23, 2020 · 12 comments
Assignees
Labels

Comments

@mreitenb
Copy link

System information:

  • Windows OS version: Windows 10 Home 1909
  • ImageGlass version: 8.0.12.8
  • Brand new Asus Zenbook laptop

To Reproduce

Steps to reproduce the behavior:

  1. Enable touch gesture support in Settings -> General (enabled by default)

Actual behavior:

Two-finger left/right swipe has no effect.
Pinch-to-zoom displays the previous/next image.

Expected behavior:

Two-finger left/right swipe should display the previous/next image.
Pinch-to-zoom should zoom in/out.

@fire-eggs
Copy link
Collaborator

Please show your current settings for "Mouse wheel actions" in Settings -> Image.

Microsoft has combined touch and mouse wheel behaviors; if any of your "Mouse wheel actions" settings are configured to "Previous/next image", try switching to "Zoom".

Does Asus have any custom drivers / controls for touch / touch-pad behavior?

@mreitenb
Copy link
Author

It didn't work with the default mouse wheel settings (which I forgot). I set the regular mouse wheel action to "Previous/next image" and the other three to "Zoom". The results are: 1. Pinch-to-zoom works, 2. Two-finger up/down swipe cycles through the images very quickly, 3. Two-finger left/right swipe does not work.

Windows Device Manager shows that an Asus driver is used, but there is no custom control panel for touch-pad behavior. Two-finger left/right swipe works OK in other apps, such as Chrome.

@fire-eggs
Copy link
Collaborator

I forgot to ask ... Does single finger swipe work for previous / next?

Here's what IG had at the end of 2019:

  • swipe left/right for previous/next picture
  • rotate in either direction (90-degree)
  • zoom in/out at a location via spread/pinch
  • zoom in/out via swipe up/down

Can you explain why specifically two-finger swipe?

Thanks!

@mreitenb
Copy link
Author

My comments refer to a touchpad, the type that every laptop has, not a touchscreen. Single finger swipe doesn't make sense for a touchpad, since single finger movement just moves the cursor.

@d2phap
Copy link
Owner

d2phap commented Dec 24, 2020

@mreitenb
Can you try unchecking Enable touch gestures support as reported at #709
However, ImageGlass does not officially support touchpad gestures (#305).

image

@mreitenb
Copy link
Author

Unchecking this box does not make a difference.

@fire-eggs
Copy link
Collaborator

I had to remind myself about gesture handling and the relevant IG code. Looks like a bug, sorry about all the back-and-forth.

First, IG's gesture handling is coded to be supported only when "Enable touch" option is ON.

Second, the code "should" have worked for touchpad, but obviously is not. IG's gesture handling code needs to be revisited for touchpad as well as touch.

@fire-eggs fire-eggs changed the title Touch Gestures Messed Up Touchpad Gestures Messed Up Dec 24, 2020
@fire-eggs fire-eggs self-assigned this Dec 24, 2020
@mreitenb
Copy link
Author

OK, thanks for looking into it. I will keep my eyes open for future commits.

@BradKML
Copy link

BradKML commented Apr 18, 2021

Would like to know when the next release comes out to fix this

@mreitenb
Copy link
Author

mreitenb commented Apr 18, 2021 via email

@Sasiko
Copy link

Sasiko commented Jul 31, 2022

on windows 11, also tried disabling and enabling touch gesture support but it doesnt work. i tried pinch zoom in but no gesture works at all.

@worldsdream
Copy link

Touchpad is also not working for me. So I can't use Pinch to Zoom functionality.

Version 8.9.6.9 x64 (Windows)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants