Skip to content

Commit b155968

Browse files
committed
Fix tests. Fixes #6.
1 parent 96bb718 commit b155968

File tree

4 files changed

+19
-13
lines changed

4 files changed

+19
-13
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "d3-request",
3-
"version": "0.2.2",
3+
"version": "0.2.3",
44
"description": "A convenient alternative to XMLHttpRequest.",
55
"keywords": [
66
"d3",

test/csv-test.js

+7-6
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
var tape = require("tape"),
2-
request = require("../");
2+
request = require("../"),
3+
table = require("./table");
34

45
require("./XMLHttpRequest");
56

@@ -10,7 +11,7 @@ tape("csv(url, callback) makes an asynchronous GET request for a CSV file", func
1011
test.equal(XMLHttpRequest._last._info.method, "GET");
1112
test.equal(XMLHttpRequest._last._info.async, true);
1213
test.equal(XMLHttpRequest._last._info.mimeType, "text/csv");
13-
test.deepEqual(data, [{Hello: "42", World: "\"fish\""}]);
14+
test.deepEqual(data, table([{Hello: "42", World: "\"fish\""}], ["Hello", "World"]));
1415
test.end();
1516
});
1617
});
@@ -22,31 +23,31 @@ tape("csv(url, callback) is an alias csv(url).get(callback)", function(test) {
2223
test.equal(XMLHttpRequest._last._info.method, "GET");
2324
test.equal(XMLHttpRequest._last._info.async, true);
2425
test.equal(XMLHttpRequest._last._info.mimeType, "text/csv");
25-
test.deepEqual(data, [{Hello: "42", World: "\"fish\""}]);
26+
test.deepEqual(data, table([{Hello: "42", World: "\"fish\""}], ["Hello", "World"]));
2627
test.end();
2728
});
2829
});
2930

3031
tape("csv(url, row, callback) observes the specified row conversion function", function(test) {
3132
request.csv("test/data/sample.csv", function(d) { d.Hello = -d.Hello; return d; }, function(error, data) {
3233
if (error) throw error;
33-
test.deepEqual(data, [{Hello: -42, World: "\"fish\""}]);
34+
test.deepEqual(data, table([{Hello: -42, World: "\"fish\""}], ["Hello", "World"]));
3435
test.end();
3536
});
3637
});
3738

3839
tape("csv(url, row, callback) is an alias for csv(url).row(row).get(callback)", function(test) {
3940
request.csv("test/data/sample.csv").row(function(d) { d.Hello = -d.Hello; return d; }).get(function(error, data) {
4041
if (error) throw error;
41-
test.deepEqual(data, [{Hello: -42, World: "\"fish\""}]);
42+
test.deepEqual(data, table([{Hello: -42, World: "\"fish\""}], ["Hello", "World"]));
4243
test.end();
4344
});
4445
});
4546

4647
tape("csv(url).mimeType(type).get(callback) observes the specified mime type", function(test) {
4748
request.csv("test/data/sample.csv").mimeType("text/plain").get(function(error, data) {
4849
if (error) throw error;
49-
test.deepEqual(data, [{Hello: "42", World: "\"fish\""}]);
50+
test.deepEqual(data, table([{Hello: "42", World: "\"fish\""}], ["Hello", "World"]));
5051
test.equal(XMLHttpRequest._last._info.mimeType, "text/plain");
5152
test.end();
5253
});

test/table.js

+4
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
module.exports = function(rows, columns) {
2+
rows.columns = columns;
3+
return rows;
4+
};

test/tsv-test.js

+7-6
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
var tape = require("tape"),
2-
request = require("../");
2+
request = require("../"),
3+
table = require("./table");
34

45
require("./XMLHttpRequest");
56

@@ -10,7 +11,7 @@ tape("tsv(url, callback) makes an asynchronous GET request for a TSV file", func
1011
test.equal(XMLHttpRequest._last._info.method, "GET");
1112
test.equal(XMLHttpRequest._last._info.async, true);
1213
test.equal(XMLHttpRequest._last._info.mimeType, "text/tab-separated-values");
13-
test.deepEqual(data, [{Hello: "42", World: "\"fish\""}]);
14+
test.deepEqual(data, table([{Hello: "42", World: "\"fish\""}], ["Hello", "World"]));
1415
test.end();
1516
});
1617
});
@@ -22,31 +23,31 @@ tape("tsv(url, callback) is an alias tsv(url).get(callback)", function(test) {
2223
test.equal(XMLHttpRequest._last._info.method, "GET");
2324
test.equal(XMLHttpRequest._last._info.async, true);
2425
test.equal(XMLHttpRequest._last._info.mimeType, "text/tab-separated-values");
25-
test.deepEqual(data, [{Hello: "42", World: "\"fish\""}]);
26+
test.deepEqual(data, table([{Hello: "42", World: "\"fish\""}], ["Hello", "World"]));
2627
test.end();
2728
});
2829
});
2930

3031
tape("tsv(url, row, callback) observes the specified row conversion function", function(test) {
3132
request.tsv("test/data/sample.tsv", function(d) { d.Hello = -d.Hello; return d; }, function(error, data) {
3233
if (error) throw error;
33-
test.deepEqual(data, [{Hello: -42, World: "\"fish\""}]);
34+
test.deepEqual(data, table([{Hello: -42, World: "\"fish\""}], ["Hello", "World"]));
3435
test.end();
3536
});
3637
});
3738

3839
tape("tsv(url, row, callback) is an alias for tsv(url).row(row).get(callback)", function(test) {
3940
request.tsv("test/data/sample.tsv").row(function(d) { d.Hello = -d.Hello; return d; }).get(function(error, data) {
4041
if (error) throw error;
41-
test.deepEqual(data, [{Hello: -42, World: "\"fish\""}]);
42+
test.deepEqual(data, table([{Hello: -42, World: "\"fish\""}], ["Hello", "World"]));
4243
test.end();
4344
});
4445
});
4546

4647
tape("tsv(url).mimeType(type).get(callback) observes the specified mime type", function(test) {
4748
request.tsv("test/data/sample.tsv").mimeType("text/plain").get(function(error, data) {
4849
if (error) throw error;
49-
test.deepEqual(data, [{Hello: "42", World: "\"fish\""}]);
50+
test.deepEqual(data, table([{Hello: "42", World: "\"fish\""}], ["Hello", "World"]));
5051
test.equal(XMLHttpRequest._last._info.mimeType, "text/plain");
5152
test.end();
5253
});

0 commit comments

Comments
 (0)