Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New major versions? #736

Open
tarcieri opened this issue Mar 18, 2025 · 1 comment
Open

New major versions? #736

tarcieri opened this issue Mar 18, 2025 · 1 comment

Comments

@tarcieri
Copy link
Contributor

Sometime in the next few months we'll be releasing new versions of the @RustCrypto crates.

I would like to get a vibe check on how people would feel about not bumping the major versions of the dalek crates (curve25519-dalek, ed25519-dalek, x25519-dalek) as part of this release.

Major version bumps are hard. This crate is often exposed in public APIs. For example it took Solana well over a year to update. Even now about 20% of downloads are for obsolete versions.

There isn't an explicit need to bump major versions: the existing SemVer policy allows for such upgrades along minor version boundaries. However, not everyone may have read about that or how to pin versions correctly and will open angry issues when cargo update fails to work.

Note the @RustCrypto crates will also carry a 2024 edition bump, which exacerbates the problems with an unhelpful error message when using Rust versions older than 1.85.

A major version bump might make this whole upgrade process smoother by avoiding breaking changes to the @RustCrypto crates. It would also provide an opportunity to remove previously deprecated APIs and make other breaking changes. See also: #476

I'm asking mainly because ed25519-dalek is one of the most notable consumers of the signature crate aside from the @RustCrypto crates and there are some potential unrelated breaking changes it would be nice to make there, but doing those would require a major version bump of ed25519-dalek at the very least. If we-as-dalek decide that bumping major version is unwarranted or too much of a hassle, we can similarly avoid a breaking release of the signature crate.

@rozbb
Copy link
Contributor

rozbb commented Mar 19, 2025

I'm personally fine doing a major version bump. The changes will end up being concretely small, and I think it's perfectly healthy for a project to do major version bumps periodically. Low confidence opinion though, so I'll defer to you if you feel strongly in the opposite direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants