Skip to content

Commit bc229d0

Browse files
committed
build: reduce noise from doc target
The doc target currently echos the complete shell command, which might produces a lot of output. Using this change the actual commands run are still shown. Before: [ -e tools/doc/node_modules/js-yaml/package.json ] || \ [ -e tools/eslint/node_modules/js-yaml/package.json ] || \ if [ -x ./node ]; then \ cd tools/doc && ../.././node ../.././deps/npm/bin/npm-cli.js install; \ else \ cd tools/doc && node ../.././deps/npm/bin/npm-cli.js install; \ fi [ -x ./node ] && ./node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html || node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html Input file = doc/api/assert.md After: [ -x ./node ] && ./node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html || node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html Input file = doc/api/assert.md To verify run: $ make docclean $ make doc PR-URL: nodejs#9457 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James Snell <jasnell@gmail.com>
1 parent 4463d2b commit bc229d0

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Makefile

+2-2
Original file line numberDiff line numberDiff line change
@@ -315,7 +315,7 @@ out/doc/%: doc/%
315315
# check if ./node is actually set, else use user pre-installed binary
316316
gen-json = tools/doc/generate.js --format=json $< > $@
317317
out/doc/api/%.json: doc/api/%.md
318-
[ -e tools/doc/node_modules/js-yaml/package.json ] || \
318+
@[ -e tools/doc/node_modules/js-yaml/package.json ] || \
319319
[ -e tools/eslint/node_modules/js-yaml/package.json ] || \
320320
if [ -x $(NODE) ]; then \
321321
cd tools/doc && ../../$(NODE) ../../$(NPM) install; \
@@ -327,7 +327,7 @@ out/doc/api/%.json: doc/api/%.md
327327
# check if ./node is actually set, else use user pre-installed binary
328328
gen-html = tools/doc/generate.js --node-version=$(FULLVERSION) --format=html --template=doc/template.html $< > $@
329329
out/doc/api/%.html: doc/api/%.md
330-
[ -e tools/doc/node_modules/js-yaml/package.json ] || \
330+
@[ -e tools/doc/node_modules/js-yaml/package.json ] || \
331331
[ -e tools/eslint/node_modules/js-yaml/package.json ] || \
332332
if [ -x $(NODE) ]; then \
333333
cd tools/doc && ../../$(NODE) ../../$(NPM) install; \

0 commit comments

Comments
 (0)