Skip to content

Commit c6bc5f3

Browse files
dauinsightJavad
and
Javad
committed
SDL | Changing ReadXml to a more secure overload. (dotnet#2147) (dotnet#2490)
Co-authored-by: Javad <v-jarahn@microsoft.com>
1 parent 652ca96 commit c6bc5f3

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

src/Microsoft.Data.SqlClient/src/Microsoft/Data/ProviderBase/DbMetaDataFactory.cs

+8-2
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
using System.Diagnostics;
1010
using System.Globalization;
1111
using System.IO;
12+
using System.Xml;
1213

1314
namespace Microsoft.Data.ProviderBase
1415
{
@@ -499,9 +500,14 @@ private void LoadDataSetFromXml(Stream XmlStream)
499500
{
500501
_metaDataCollectionsDataSet = new DataSet
501502
{
502-
Locale = System.Globalization.CultureInfo.InvariantCulture
503+
Locale = CultureInfo.InvariantCulture
504+
};
505+
XmlReaderSettings settings = new()
506+
{
507+
XmlResolver = null
503508
};
504-
_metaDataCollectionsDataSet.ReadXml(XmlStream);
509+
using XmlReader reader = XmlReader.Create(XmlStream, settings);
510+
_metaDataCollectionsDataSet.ReadXml(reader);
505511
}
506512

507513
protected virtual DataTable PrepareCollection(string collectionName, string[] restrictions, DbConnection connection)

0 commit comments

Comments
 (0)