Handle missing giphy image sizes

Author: davidje13

src/backend/src/api-tests/giphy.test.ts

@@ -14,10 +14,16 @@ describe('API giphy', () => {
         data: [
           {
             images: {
-              fixed_height: { url: 'normal.gif?extra' },
+              original: { url: 'original.gif?extra' },
+              fixed_height: { url: 'medium.gif?extra' },
               fixed_height_small: { url: 'small.gif?extra' },
             },
           },
+          {
+            images: {
+              original: { url: 'original2.gif' },
+            },
+          },
         ],
       });
     });
@@ -48,7 +54,10 @@ describe('API giphy', () => {
         .expect('Content-Type', /application\/json/);
 
       expect(response.body).toEqual({
-        gifs: [{ small: 'small.gif', medium: 'normal.gif' }],
+        gifs: [
+          { small: 'small.gif', medium: 'medium.gif' },
+          { small: 'original2.gif', medium: 'original2.gif' },
+        ],
       });
     });
 

src/backend/src/services/GiphyService.ts

@@ -14,13 +14,14 @@ interface GifInfo {
 }
 
 interface GiphyResponseResource {
-  url: string;
+  url?: string;
 }
 
 interface GiphyResponseGif {
   images: {
-    fixed_height: GiphyResponseResource;
-    fixed_height_small: GiphyResponseResource;
+    original?: GiphyResponseResource;
+    fixed_height?: GiphyResponseResource;
+    fixed_height_small?: GiphyResponseResource;
   };
 }
 
@@ -75,10 +76,15 @@ export class GiphyService {
           throw new Error(`Unknown Giphy API response: ${resultJson.status}`);
         }
 
-        return resultJson.data.map((gif) => ({
-          small: gif.images.fixed_height_small.url.split('?')[0] ?? '',
-          medium: gif.images.fixed_height.url.split('?')[0] ?? '',
-        }));
+        return resultJson.data.map((gif) => {
+          const original = gif.images.original?.url ?? '';
+          const fixed = gif.images.fixed_height?.url ?? original;
+          const small = gif.images.fixed_height_small?.url ?? fixed;
+          return {
+            small: small.split('?')[0] ?? '',
+            medium: fixed.split('?')[0] ?? '',
+          };
+        });
       },
       (c) => c.length >= limit,
     );