Skip to content

Commit dbea47c

Browse files
committed
Fix various warnings and browser differences, use larger background blur to allow lower quality (improved performance)
1 parent 98dbb87 commit dbea47c

File tree

7 files changed

+19
-20
lines changed

7 files changed

+19
-20
lines changed

backend/src/services/RetroService.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import srb, { type Permission } from 'shared-reducer-backend';
1010
import { type Retro, type RetroSummary } from '../shared/api-entities';
1111
import { extractRetro } from '../helpers/jsonParsers';
1212

13-
const VALID_SLUG = /^[a-z0-9][a-z0-9_-]*$/;
13+
const VALID_SLUG = /^[a-z0-9][a-z0-9_\-]*$/;
1414
const MAX_SLUG_LENGTH = 64;
1515

1616
function validateSlug(slug: string): void {

backend/src/tokens/TokenManager.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { TokenManager, type KeyPair } from './TokenManager';
22
import 'lean-test';
33

4-
const JWT_PATTERN = /^([a-zA-Z0-9_-]+(\.|$)){3}$/;
4+
const JWT_PATTERN = /^([a-zA-Z0-9_\-]+(\.|$)){3}$/;
55

66
describe('TokenManager', () => {
77
const manager = new TokenManager();

frontend/package-lock.json

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

frontend/src/components/common/Popup.less

+3-13
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@
55
right: 0;
66
bottom: 0;
77
background: rgba(128, 128, 128, 0.5);
8+
backdrop-filter: blur(10px);
9+
-webkit-backdrop-filter: blur(10px);
810
z-index: 10;
911

10-
animation:
11-
0.2s ease popup-fade-in,
12-
0.05s 0.2s step-end forwards popup-blur-background;
12+
animation: 0.2s ease popup-fade-in;
1313

1414
.popup-content {
1515
position: absolute;
@@ -54,16 +54,6 @@
5454
}
5555
}
5656

57-
@keyframes popup-blur-background {
58-
from {
59-
backdrop-filter: none;
60-
}
61-
62-
to {
63-
backdrop-filter: blur(2px);
64-
}
65-
}
66-
6757
@keyframes popup-float-in {
6858
from {
6959
transform: translate(-50%, -50%) scale(0.9);

frontend/src/components/retro-create/SlugEntry.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import TickBold from '../../../resources/tick-bold.svg';
66
import Cross from '../../../resources/cross.svg';
77

88
export const MAX_SLUG_LENGTH = 64;
9-
const VALID_SLUG_PATTERN = '^[a-z0-9][a-z0-9_-]*$';
9+
const VALID_SLUG_PATTERN = '^[a-z0-9][a-z0-9_\\-]*$';
1010
const VALID_SLUG = new RegExp(VALID_SLUG_PATTERN);
1111

1212
enum SlugAvailability {

frontend/src/components/retro-formats/mood/MoodRetro.less

+3-1
Original file line numberDiff line numberDiff line change
@@ -376,10 +376,12 @@
376376
padding: 16px 0;
377377
margin: -16px 0;
378378
background: rgba(@beige-back, 0.9);
379-
backdrop-filter: blur(2px);
379+
backdrop-filter: blur(10px);
380+
-webkit-backdrop-filter: blur(10px);
380381
@media (prefers-reduced-transparency: reduce) {
381382
background: @beige-back;
382383
backdrop-filter: none;
384+
-webkit-backdrop-filter: none;
383385
}
384386
position: sticky;
385387
bottom: 0;

frontend/src/index.less

+7
Original file line numberDiff line numberDiff line change
@@ -44,3 +44,10 @@ button {
4444
textarea {
4545
min-width: 0; /* remove FireFox default */
4646
}
47+
48+
/* match browser defaults */
49+
input::placeholder,
50+
textarea::placeholder {
51+
opacity: 1;
52+
color: rgba(0, 0, 0, 0.5);
53+
}

0 commit comments

Comments
 (0)