Update to use Node 18 for building, remove testing on Node 14, add testing on Node 19

Author: davidje13

.github/workflows/ci.yml

@@ -18,7 +18,7 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v2
         with:
-          node-version: "16"
+          node-version: "18"
           cache: npm
           cache-dependency-path: 'src/*/package-lock.json'
       - name: Build and Test
@@ -44,9 +44,9 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - { node: '14' }
           - { node: '16' }
-          - { node: '17' }
+          - { node: '18' }
+          - { node: '19' }
     steps:
       - name: Install Node
         uses: actions/setup-node@v2

.travis.yml

@@ -1,6 +1,6 @@
 language: node_js
 node_js:
-- '14'
+- '18'
 - node
 os: linux
 addons:

ci/gitlab.yml

@@ -10,13 +10,13 @@ before_script:
 - tar -xf geckodriver-linux64.tar.gz
 - install geckodriver /usr/local/bin
 
-node:14:
-  image: node:14
+node:16:
+  image: node:16
   script:
   - PARALLEL_BUILD=false PARALLEL_E2E=false E2E_LAUNCH_DELAY=5 EXPLICIT_WAIT_TIMEOUT=20000 TEST_TIMEOUT=60000 DOCKER=true npm test
 
-node:16:
-  image: node:16
+node:18:
+  image: node:18
   script:
   - PARALLEL_BUILD=false PARALLEL_E2E=false E2E_LAUNCH_DELAY=5 EXPLICIT_WAIT_TIMEOUT=20000 TEST_TIMEOUT=60000 DOCKER=true npm test
 

deployment/Dockerfile

@@ -1,4 +1,4 @@
-FROM node:14-alpine AS builder
+FROM node:18-alpine AS builder
 RUN apk add --no-cache \
   g++ \
   git \
@@ -9,7 +9,7 @@ WORKDIR /refacto
 COPY . .
 RUN DISABLE_OPENCOLLECTIVE=1 npm install --production
 
-FROM node:14-alpine
+FROM node:18-alpine
 RUN addgroup -S refacto && adduser -S refacto -G refacto
 WORKDIR /refacto
 COPY --from=builder /refacto /refacto

docs/CONTRIBUTING.md

@@ -169,15 +169,17 @@ installed (see [Running tests](#running-tests)).
 
 ### `error:0308010C:digital envelope routines::unsupported`
 
-This project uses an old version of WebPack which is incompatible with Node 17. You can either
-downgrade to Node 16, or use the following command to build:
+This project uses an old version of WebPack which is incompatible with Node 17+.
+If you see this error, set the following environment variable for the command you are running:
 
 ```bash
-NODE_OPTIONS=--openssl-legacy-provider npm run build
+NODE_OPTIONS=--openssl-legacy-provider
 ```
 
-(same change for `test` etc.)
-
 Specifically, WebPack uses an old OpenSSL algorithm for generating file hashes. This is not a
 security risk, and the resulting executable can (and should) be executed without using the
 legacy provider.
+
+Fixing this properly requires updating to the next major version of WebPack, which is unfortunately
+not compatible with the NeutrinoJS build system used here. It will be necessary to replace neutrino
+with per-tool configuration to do the update.

src/backend/package.json

@@ -3,7 +3,7 @@
   "private": true,
   "scripts": {
     "prebuild": "rewrite-tsconfig",
-    "build": "NODE_OPTIONS=--openssl-legacy-provider --mode production",
+    "build": "NODE_OPTIONS=--openssl-legacy-provider webpack --mode production",
     "start": "NODE_OPTIONS=--openssl-legacy-provider webpack --watch --mode development",
     "lint:eslint": "rewrite-tsconfig && eslint --format codeframe --report-unused-disable-directives --max-warnings=0 src",
     "lint:tsc": "rewrite-tsconfig && tsc",