test: improve user tests

Author: deboracosilveira

Gemfile

@@ -62,6 +62,8 @@ gem 'rack-cors', '1.1.1'
 group :development, :test do
   # See https://guides.rubyonrails.org/debugging_rails_applications.html#debugging-with-the-debug-gem
   gem "debug", platforms: %i[ mri mingw x64_mingw ]
+  gem 'factory_bot_rails', '6.2.0'
+  gem 'ffaker', '2.20.0'
   gem "rspec-rails"
   gem "rubocop-rspec"
 end
@@ -79,6 +81,7 @@ end
 
 group :test do
   # Use system testing [https://guides.rubyonrails.org/testing.html#system-testing]
+  gem 'database_cleaner-active_record', '2.0.1'
   gem "capybara"
   gem "selenium-webdriver"
   gem "webdrivers"

Gemfile.lock

@@ -97,6 +97,10 @@ GEM
     childprocess (4.1.0)
     concurrent-ruby (1.1.9)
     crass (1.0.6)
+    database_cleaner-active_record (2.0.1)
+      activerecord (>= 5.a)
+      database_cleaner-core (~> 2.0.0)
+    database_cleaner-core (2.0.1)
     debug (1.4.0)
       irb (>= 1.3.6)
       reline (>= 0.2.7)
@@ -122,6 +126,12 @@ GEM
     dry-core (0.7.1)
       concurrent-ruby (~> 1.0)
     erubi (1.10.0)
+    factory_bot (6.2.0)
+      activesupport (>= 5.0.0)
+    factory_bot_rails (6.2.0)
+      factory_bot (~> 6.2.0)
+      railties (>= 5.0.0)
+    ffaker (2.20.0)
     ffi (1.15.5)
     globalid (1.0.0)
       activesupport (>= 5.0)
@@ -170,25 +180,25 @@ GEM
       net-protocol
       timeout
     nio4r (2.5.8)
-    nokogiri (1.13.2-aarch64-linux)
+    nokogiri (1.13.3-aarch64-linux)
       racc (~> 1.4)
-    nokogiri (1.13.2-arm64-darwin)
+    nokogiri (1.13.3-arm64-darwin)
       racc (~> 1.4)
-    nokogiri (1.13.2-x86_64-linux)
+    nokogiri (1.13.3-x86_64-linux)
       racc (~> 1.4)
     orm_adapter (0.5.0)
     parallel (1.21.0)
     parser (3.1.1.0)
       ast (~> 2.4.1)
-    pg (1.3.2)
+    pg (1.3.3)
     public_suffix (4.0.6)
     puma (5.6.2)
       nio4r (~> 2.0)
     racc (1.6.0)
     rack (2.2.3)
     rack-cors (1.1.1)
       rack (>= 2.0.0)
-    rack-mini-profiler (2.3.3)
+    rack-mini-profiler (2.3.4)
       rack (>= 1.2.0)
     rack-test (1.1.0)
       rack (>= 1.0, < 3)
@@ -254,8 +264,8 @@ GEM
       rubocop-ast (>= 1.15.1, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.15.2)
-      parser (>= 3.0.1.1)
+    rubocop-ast (1.16.0)
+      parser (>= 3.1.1.0)
     rubocop-rails (2.13.2)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
@@ -277,7 +287,7 @@ GEM
       actionpack (>= 5.2)
       activesupport (>= 5.2)
       sprockets (>= 3.0.0)
-    stimulus-rails (1.0.3)
+    stimulus-rails (1.0.4)
       railties (>= 6.0.0)
     strscan (3.0.1)
     thor (1.2.1)
@@ -323,9 +333,12 @@ DEPENDENCIES
   brakeman
   bundler-audit
   capybara
+  database_cleaner-active_record (= 2.0.1)
   debug
   devise (= 4.8.1)
   devise-jwt (= 0.9.0)
+  factory_bot_rails (= 6.2.0)
+  ffaker (= 2.20.0)
   image_processing (~> 1.2)
   importmap-rails
   jbuilder

config/environments/development.rb

@@ -2,6 +2,8 @@
 
 require 'active_support/core_ext/integer/time'
 
+Rails.application.routes.default_url_options[:host] = 'localhost:3001'
+
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.
 

config/environments/test.rb

@@ -7,6 +7,8 @@
 # your test database is "scratch space" for the test suite and is wiped
 # and recreated between test runs. Don't rely on the data there!
 
+Rails.application.routes.default_url_options[:host] = 'localhost:3001'
+
 Rails.application.configure do
   # Settings specified here will take precedence over those in config/application.rb.
 
@@ -38,7 +40,9 @@
   # Store uploaded files on the local file system in a temporary directory.
   config.active_storage.service = :test
 
-  config.action_mailer.perform_caching = false
+  config.action_mailer.default_url_options = { host: 'localhost', port: 3001 }
+
+  config.action_mailer.perform_caching = true
 
   # Tell Action Mailer not to deliver emails to the real world.
   # The :test delivery method accumulates sent emails in the

spec/controllers/confirmations_controller_spec.rb

@@ -0,0 +1,12 @@
+require 'rails_helper'
+
+RSpec.describe Users::ConfirmationsController, type: :controller do    
+  it "checks user is confirmed with token received by email" do
+    user = FactoryBot.create(:user)
+
+    received_token = Devise.mailer.deliveries.last.body.match(/confirmation_token=(.+)">/x)[1]
+    user = User.confirm_by_token(received_token)
+
+    expect(user.reload.confirmed?).to be(true)
+  end
+end

spec/controllers/registrations_controller_spec.rb

@@ -0,0 +1,32 @@
+require 'rails_helper'
+
+RSpec.describe Users::RegistrationsController, type: :controller do
+  describe "after registration" do
+    it "user is not confirmed" do
+      user = FactoryBot.create :user
+      expect(user.confirmed?).to_not be true
+    end
+
+    it "sends welcome/confirmation email" do
+      user = FactoryBot.build :user
+
+      expect { user.save }.to change(Devise.mailer.deliveries, :count).by(1)
+    end
+  
+    describe "check that email" do
+      it "was sent to correct email" do
+        user = FactoryBot.create :user
+
+        confirmation_email = Devise.mailer.deliveries.last
+        expect(user.email).to eq confirmation_email.to[0]
+      end
+
+      it "contains welcome message" do
+        user = FactoryBot.create :user
+
+        confirmation_email = Devise.mailer.deliveries.last
+        expect(confirmation_email.body.to_s).to have_content 'Welcome'
+      end
+    end
+  end
+end

spec/factories/user.rb

@@ -0,0 +1,7 @@
+FactoryBot.define do
+  factory :user do
+    email { FFaker::Internet.email }
+    name { FFaker::Name.name }
+    password { 'password' }
+  end
+end

spec/models/.keep

@@ -1,41 +1,36 @@
 require 'rails_helper'
 
 RSpec.describe User, type: :model do
-  subject {
-    described_class.new(email: "john@doe.com",
-                        name: 'John',
-                        password: "john_password",
-    )
-  }
+  user = FactoryBot.create(:user)
 
   describe "Validations" do
     it "should be valid" do
-      expect(subject).to be_valid
+      expect(user).to be_valid
     end
 
     it "should not be valid without an email" do
-      subject.email = nil
-      expect(subject).to_not be_valid
+      user.email = nil
+      expect(user).to_not be_valid
     end
 
     it "should not be valid without a name" do
-      subject.name = nil
-      expect(subject).to_not be_valid
+      user.name = nil
+      expect(user).to_not be_valid
     end
 
     it "name should be less than 32 characters" do
-      subject.name = "this is a very very very long name"
-      expect(subject).to_not be_valid
+      user.name = "this is a very very very long name"
+      expect(user).to_not be_valid
     end
 
     it "should not be valid without a password" do
-      subject.password = nil
-      expect(subject).to_not be_valid
+      user.password = nil
+      expect(user).to_not be_valid
     end
 
-    it "password must be at least 6 characters" do
-      subject.password = '12'
-      expect(subject).to_not be_valid
+    it "password must have at least 6 characters" do
+      user.password = '12'
+      expect(user).to_not be_valid
     end
   end
 end

spec/models/user_spec.rb

@@ -6,6 +6,8 @@
 require File.expand_path('../config/environment', __dir__)
 # Prevent database truncation if the environment is production
 abort('The Rails environment is running in production mode!') if Rails.env.production?
+
+require 'factory_bot_rails'
 require 'rspec/rails'
 # Add additional requires below this line. Rails is not loaded until this point!
 
@@ -63,4 +65,8 @@
   config.filter_rails_from_backtrace!
   # arbitrary gems may also be filtered via:
   # config.filter_gems_from_backtrace("gem name")
+
+  config.before(:suite) do
+    DatabaseCleaner.clean_with(:truncation)
+    DatabaseCleaner.strategy = :transaction  end
 end

spec/rails_helper.rb

@@ -16,6 +16,10 @@
 #
 # See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 RSpec.configure do |config|
+  config.before(:suite) do
+    DatabaseCleaner.clean_with(:truncation)
+  end
+
   # rspec-expectations config goes here. You can use an alternate
   # assertion/expectation library such as wrong or the stdlib/minitest
   # assertions if you prefer.

spec/spec_helper.rb

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+RSpec.configure do |config|
+  config.include FactoryBot::Syntax::Methods
+end