Addresses Pierluca's comments

- use a make file to build
- fixes wrong command description

Author: nkcr

Makefile

@@ -1,3 +1,6 @@
+versionFlag="github.com/dedis/d-voting.Version=$(shell git describe --tags)"
+timeFlag="github.com/dedis/d-voting.BuildTime=$(shell date +'%d/%m/%y_%H:%M')"
+
 lint:
 	# Coding style static check.
 	@go get -v honnef.co/go/tools/cmd/staticcheck
@@ -16,4 +19,7 @@ check: lint vet
 	go test `go list ./... | grep -v /integration`
 
 test_integration:
-	go test ./integration
+	go test ./integration
+
+build:
+	go build -ldflags="-X $(versionFlag) -X $(timeFlag)" ./cli/memcoin

README.md

@@ -174,7 +174,7 @@ serves those metrics with:
 ./memcoin --config /tmp/node1 metrics start --addr 127.0.0.1:9100 --path /metrics
 ```
 
-Build info can be added to the binary with the `ldflags`, at build time.. Infos
+Build info can be added to the binary with the `ldflags`, at build time. Infos
 are stored on variables in the root `mod.go`. For example:
 
 ```sh
@@ -184,3 +184,4 @@ timeFlag="github.com/dedis/d-voting.BuildTime=`date +'%d/%m/%y_%H:%M'`"
 go build -ldflags="-X $versionFlag -X $timeFlag" ./cli/memcoin
 ```
 
+Note that `make build` will do that for you.

metrics/controller/mod.go

@@ -19,7 +19,7 @@ type controller struct{}
 func (m controller) SetCommands(builder node.Builder) {
 
 	cmd := builder.SetCommand("metrics")
-	cmd.SetDescription("interact with the DKG service")
+	cmd.SetDescription("register Prometheus metrics and servers them via HTTP")
 
 	sub := cmd.SetSubCommand("start")
 	sub.SetDescription("start an http server to server Prometheus metrics")

start_test.sh

@@ -7,10 +7,7 @@ set -o errexit
 
 command -v tmux >/dev/null 2>&1 || { echo >&2 "tmux is not on your PATH!"; exit 1; }
 
-versionFlag="github.com/dedis/d-voting.Version=`git describe --tags`"
-timeFlag="github.com/dedis/d-voting.BuildTime=`date +'%d/%m/%y_%H:%M'`"
-
-go build -ldflags="-X $versionFlag -X $timeFlag" ./cli/memcoin
+make build
 
 # Launch session
 s="d-voting-test"