Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internalisation - forms are not correctly displayed in list of forms #309

Closed
PascalinDe opened this issue Aug 25, 2023 · 10 comments · Fixed by #317
Closed

Internalisation - forms are not correctly displayed in list of forms #309

PascalinDe opened this issue Aug 25, 2023 · 10 comments · Fixed by #317
Assignees

Comments

@PascalinDe
Copy link
Contributor

PascalinDe commented Aug 25, 2023

Screenshot 2023-08-25 at 15-09-21 D-Voting

no title or clickable link is shown, making the form inaccessible

the problem seems to be in the frontend, since the backend returns the correct data:

{"Forms":[{"FormID":"78715f535155153ff37846149391ad128b8f5f423d9a9c9e476fa9f98e9dfbfb","Title":"{\"en\":\"Starter Pokémon\",\"fr\":\"\",\"de\":\"\"}","Status":0,"Pubkey":""},{"FormID":"49f21d11e17b593c1b45146d9fb249f25d2a1bd4642ec98c2892a3fadf4b3f29","Title":"{\"en\":\"Starter Pokémon\",\"fr\":\"\",\"de\":\"\"}","Status":0,"Pubkey":""}]}

@PascalinDe
Copy link
Contributor Author

reproduced on Firefox 116 and Chromium 115

@PascalinDe PascalinDe self-assigned this Aug 25, 2023
@PascalinDe
Copy link
Contributor Author

PascalinDe commented Aug 29, 2023

@pierluca the problem seems to be the way that the language is handled

I'd let i18n handle the language as one can define fallbacks there in case the language is unknown

my question is: should one of the title languages be required (i.e. always an English title) as opposed to "as long as it has any title it's fine"? imho, one language site should always have every content (French? English? what's the policy at EPFL?)

@ineiti
Copy link
Member

ineiti commented Aug 29, 2023

imho, one language site should always have every content

Did you mean "all content of the site should be available in the main language (...)"?

I don't know of an official EPFL policy. What I see is that labs have mostly English, while admin stuff is mostly French.

@PascalinDe
Copy link
Contributor Author

I meant "there should be at least one language version that has 100% content in that language and missing content in the other languages should default to that language's version"

e.g. francearchives.fr has its French site 100% in French, and missing content in other versions defaults to French (such as https://francearchives.gouv.fr/de/#)

@PascalinDe
Copy link
Contributor Author

I think the whole internalization needs to be overhauled

but that would probably take some time - I've added a WIP here that shows the "get it to work while also trying to steer it into a better direction variant" #313 so that might be a good starting point

@PascalinDe
Copy link
Contributor Author

#313

@PascalinDe PascalinDe linked a pull request Aug 30, 2023 that will close this issue
@PascalinDe PascalinDe reopened this Aug 31, 2023
@PascalinDe
Copy link
Contributor Author

the wrong PR got linked, it should've been #313

@PascalinDe PascalinDe changed the title forms are not correctly displayed in list of forms Internalisation - forms are not correctly displayed in list of forms Sep 1, 2023
@pierluca
Copy link
Contributor

pierluca commented Sep 1, 2023

I agree that the whole i18n needs to be overhauled. That's probably one of the most critically broken things in the front-end and the APIs.

I meant "there should be at least one language version that has 100% content in that language and missing content in the other languages should default to that language's version"

this seems the correct approach, not the

as long as it has any title it's fine

I wouldn't force it to be English or French though, but that's probably something that Lindo & Giovanni can clarify.

@PascalinDe
Copy link
Contributor Author

I wouldn't force it to be English or French though, but that's probably something that Lindo & Giovanni can clarify.

we'd have to chose one language for the 100% content language, I'll check w/ Lindo/Giovanni if defaulting to English is OK for them (as most of the interface defaults to English anyway)

@PascalinDe
Copy link
Contributor Author

with #313 merged it defaults to English titles for the moment - I close this ticket as the problem (no displayed forms) is solved, and send a message to Lindo/Giovanni for the default language discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants