Skip to content

Commit bc2d673

Browse files
drewhagenmjnagel
andauthoredAug 1, 2024··
chore: change metric server to optional (#611)
BREAKING CHANGE: metric server is no longer required and is optional. To enable it, add it to the optionalComponents key on the core package Release-As: 0.25.0 ## Description Since many of our supported Kubernetes distros (rke2, k3d, eks) often come with metrics-server or have an add-on, we make this change to optionally enable it at the uds-core layer. ## Related Issue Relates to [uds-core#176](#176) ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ x ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [ ] Test, docs, adr added or updated as needed - [ ] [Contributor Guide](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md) followed Co-authored-by: Micah Nagel <micah.nagel@defenseunicorns.com>
1 parent 9b14c2c commit bc2d673

File tree

4 files changed

+6
-1
lines changed

4 files changed

+6
-1
lines changed
 

‎.github/bundles/uds-bundle.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,8 @@ packages:
1616
# x-release-please-start-version
1717
ref: 0.24.1
1818
# x-release-please-end
19+
optionalComponents:
20+
- metrics-server
1921
overrides:
2022
velero:
2123
velero:

‎bundles/k3d-slim-dev/uds-bundle.yaml

+2
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ packages:
3636
# x-release-please-start-version
3737
ref: 0.24.1
3838
# x-release-please-end
39+
optionalComponents:
40+
- metrics-server
3941
overrides:
4042
istio-admin-gateway:
4143
uds-istio-config:

‎bundles/k3d-standard/uds-bundle.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ packages:
3838
# x-release-please-end
3939
optionalComponents:
4040
- istio-passthrough-gateway
41+
- metrics-server
4142
overrides:
4243
loki:
4344
loki:

‎src/metrics-server/common/zarf.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ metadata:
66

77
components:
88
- name: metrics-server
9-
required: true
9+
required: false # This component is optional since most k8s distros provide this out of the box
1010
charts:
1111
- name: uds-metrics-server-config
1212
namespace: metrics-server

0 commit comments

Comments
 (0)
Please sign in to comment.