chore: Added onbeforeunload to window type definition (#16251)

Author: mattezell

cli/dts/lib.deno.window.d.ts

@@ -21,6 +21,7 @@ declare class Window extends EventTarget {
   readonly self: Window & typeof globalThis;
   onerror: ((this: Window, ev: ErrorEvent) => any) | null;
   onload: ((this: Window, ev: Event) => any) | null;
+  onbeforeunload: ((this: Window, ev: Event) => any) | null;
   onunload: ((this: Window, ev: Event) => any) | null;
   onunhandledrejection:
     | ((this: Window, ev: PromiseRejectionEvent) => any)
@@ -76,6 +77,8 @@ declare var onerror: ((this: Window, ev: ErrorEvent) => any) | null;
 /** @category DOM Events */
 declare var onload: ((this: Window, ev: Event) => any) | null;
 /** @category DOM Events */
+declare var onbeforeunload: ((this: Window, ev: Event) => any) | null;
+/** @category DOM Events */
 declare var onunload: ((this: Window, ev: Event) => any) | null;
 /** @category Observability */
 declare var onunhandledrejection:

cli/tests/testdata/run/onload/imported.ts

@@ -3,10 +3,11 @@ import { assert } from "../../../../../test_util/std/testing/asserts.ts";
 import "./nest_imported.ts";
 
 const handler = (e: Event) => {
-  assert(!e.cancelable);
+  assert(e.type === "beforeunload" ? e.cancelable : !e.cancelable);
   console.log(`got ${e.type} event in event handler (imported)`);
 };
 
 window.addEventListener("load", handler);
+window.addEventListener("beforeunload", handler);
 window.addEventListener("unload", handler);
 console.log("log from imported script");

cli/tests/testdata/run/onload/main.out

@@ -5,6 +5,10 @@ got load event in event handler (nest_imported)
 got load event in event handler (imported)
 got load event in event handler (main)
 got load event in onload function
+got beforeunload event in event handler (nest_imported)
+got beforeunload event in event handler (imported)
+got beforeunload event in event handler (main)
+got beforeunload event in onbeforeunload function
 got unload event in event handler (nest_imported)
 got unload event in event handler (imported)
 got unload event in event handler (main)

cli/tests/testdata/run/onload/main.ts

@@ -6,19 +6,26 @@ assert(window.hasOwnProperty("onload"));
 assert(window.onload === null);
 
 const eventHandler = (e: Event) => {
-  assert(!e.cancelable);
+  assert(e.type === "beforeunload" ? e.cancelable : !e.cancelable);
   console.log(`got ${e.type} event in event handler (main)`);
 };
 
 window.addEventListener("load", eventHandler);
 
+window.addEventListener("beforeunload", eventHandler);
+
 window.addEventListener("unload", eventHandler);
 
 window.onload = (e: Event) => {
   assert(!e.cancelable);
   console.log(`got ${e.type} event in onload function`);
 };
 
+window.onbeforeunload = (e: BeforeUnloadEvent) => {
+  assert(e.cancelable);
+  console.log(`got ${e.type} event in onbeforeunload function`);
+};
+
 window.onunload = (e: Event) => {
   assert(!e.cancelable);
   console.log(`got ${e.type} event in onunload function`);

cli/tests/testdata/run/onload/nest_imported.ts

@@ -2,10 +2,11 @@
 import { assert } from "../../../../../test_util/std/testing/asserts.ts";
 
 const handler = (e: Event) => {
-  assert(!e.cancelable);
+  assert(e.type === "beforeunload" ? e.cancelable : !e.cancelable);
   console.log(`got ${e.type} event in event handler (nest_imported)`);
 };
 
 window.addEventListener("load", handler);
+window.addEventListener("beforeunload", handler);
 window.addEventListener("unload", handler);
 console.log("log from nest_imported script");