Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name component type "manifest" instead "kubernetes" or "openshift" #36

Closed
l0rd opened this issue Apr 7, 2020 · 2 comments
Closed

Name component type "manifest" instead "kubernetes" or "openshift" #36

l0rd opened this issue Apr 7, 2020 · 2 comments
Milestone

Comments

@l0rd
Copy link
Contributor

l0rd commented Apr 7, 2020

This a simple proposal to use the name manifest instead of kubernetes or openshift in the devfile components.

---
components:
  - container:
        name: component1
        image: maven
  - manifest:
        name: component2
       reference: https://.../mongo.yaml
  - plugin:
        id: java
@sbose78
Copy link

sbose78 commented May 12, 2020

Sounds good.

Do we want to go for reference or uri ?

@elsony
Copy link
Contributor

elsony commented Feb 11, 2021

Discussed on this and manifest is too general for tools to handle properly and we ended up will need to introduce a type to the manifest and make it more difficult to introduce type specific settings. We'll stay with the current approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants