Skip to content

Commit 1c82054

Browse files
authored
Update PULL_REQUEST_TEMPLATE.md (#106)
adopt approved PR template from api repo
1 parent 9c98ccd commit 1c82054

File tree

1 file changed

+31
-3
lines changed

1 file changed

+31
-3
lines changed

.github/PULL_REQUEST_TEMPLATE.md

+31-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,35 @@
1-
### What does this PR do?
1+
### What does this PR do?:
2+
<!-- _Summarize the changes_ -->
23

4+
### Which issue(s) this PR fixes:
5+
<!-- _Link to github issue(s)_ -->
36

4-
### What issues does this PR fix or reference?
7+
### PR acceptance criteria:
8+
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
59

10+
> - Open new test/doc issues under the [devfile/api](https://github.com/devfile/api/issues) repo
11+
> - Check each criteria if:
12+
> - There is a separate tracking issue. Add the issue link under the criteria
13+
> **or**
14+
> - test/doc updates are made as part of this PR
15+
> - If unchecked, explain why it's not needed
616
7-
### Is your PR tested? Consider putting some instruction how to test your changes
17+
18+
- [ ] Unit/Functional tests
19+
20+
<!-- _These are run as part of the PR workflow, ensure they are updated_ -->
21+
22+
- [ ] [QE Integration test](https://github.com/devfile/integration-tests)
23+
24+
<!-- _Do we need to verify integration with ODO and Openshift console?_ -->
25+
26+
- [ ] Documentation
27+
28+
<!-- _This includes product docs and READMEs._ -->
29+
30+
- [ ] Client Impact
31+
32+
<!-- _Do we have anything that can break our clients? If so, open a notifying issue_ -->
33+
34+
35+
### How to test changes / Special notes to the reviewer:

0 commit comments

Comments
 (0)