Skip to content

Commit 36607c5

Browse files
authoredOct 19, 2023
Merge pull request #180 from maysunfaisal/update-pr-template-1
Update PR template
2 parents 6aa1b83 + f25d666 commit 36607c5

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed
 

‎.github/PULL_REQUEST_TEMPLATE.md

+11-9
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,16 @@
55
<!-- _Link to github issue(s)_ -->
66

77
### PR acceptance criteria:
8-
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
8+
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened and linked to this PR, if they are not in the PR scope due to various constraints.
99

10-
> - Open new test/doc issues under the [devfile/api](https://github.com/devfile/api/issues) repo
11-
> - Check each criteria if:
12-
> - There is a separate tracking issue. Add the issue link under the criteria
13-
> **or**
14-
> - test/doc updates are made as part of this PR
15-
> - If unchecked, explain why it's not needed
10+
<!--
11+
- Open new test/doc issues under the [devfile/api](https://github.com/devfile/api/issues) repo
12+
- Check each criteria if:
13+
- There is a separate tracking issue. Add the issue link under the criteria
14+
**or**
15+
- test/doc updates are made as part of this PR
16+
- If unchecked, explain why it's not needed
17+
-->
1618

1719

1820
- [ ] Unit/Functional tests
@@ -23,9 +25,9 @@ Testing and documentation do not need to be complete in order for this PR to be
2325

2426
<!-- _Do we need to verify integration with ODO and Openshift console?_ -->
2527

26-
- [ ] Documentation
28+
- [ ] Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)
2729

28-
<!-- _This includes product docs and READMEs._ -->
30+
<!-- _This includes READMEs, Product Docs, Blogs, Education Modules, etc._ -->
2931

3032
- [ ] Client Impact
3133

0 commit comments

Comments
 (0)
Please sign in to comment.