update comment

Signed-off-by: Stephanie <yangcao@redhat.com>

Author: yangcao77

pkg/devfile/parser/parse_test.go

@@ -2395,7 +2395,7 @@ func Test_parseParentAndPlugin_RecursivelyReference(t *testing.T) {
 		}
 
 		err := parseParentAndPlugin(devFileObj, &resolutionContextTree{}, tool)
-		// devfile has a cycle in references: main devfile -> uri: http://127.0.0.1:8080 -> uri: http://127.0.0.1:9090 -> id: nodejs, registryURL: http://127.0.0.1:8090 -> uri: http://127.0.0.1:8080
+		// devfile has a cycle in references: main devfile -> uri: http://127.0.0.1:8080 -> name: testcrd, namespace: defaultnamespace -> id: nodejs, registryURL: http://127.0.0.1:8090 -> uri: http://127.0.0.1:8080
 		expectedErr := fmt.Sprintf("devfile has an cycle in references: main devfile -> uri: %s%s -> name: %s, namespace: %s -> id: nodejs, registryURL: %s%s -> uri: %s%s", httpPrefix, uri1, name, namespace,
 			httpPrefix, uri2, httpPrefix, uri1)
 		// Unexpected error

pkg/devfile/parser/resolutionContext.go

@@ -27,27 +27,24 @@ func (t *resolutionContextTree) appendNode(importReference v1.ImportReference) *
 func (t *resolutionContextTree) hasCycle() error {
 	var seenRefs []v1.ImportReference
 	currNode := t
+	hasCycle := false
+	cycle := resolveImportReference(t.importReference)
+
 	for currNode.parentNode != nil {
 		for _, seenRef := range seenRefs {
 			if reflect.DeepEqual(seenRef, currNode.importReference) {
-				return fmt.Errorf("devfile has an cycle in references: %v", formatImportCycle(t))
+				hasCycle = true
 			}
 		}
 		seenRefs = append(seenRefs, currNode.importReference)
 		currNode = currNode.parentNode
+		cycle = fmt.Sprintf("%s -> %s", resolveImportReference(currNode.importReference), cycle)
 	}
-	return nil
-}
 
-// formatImportCycle is a utility method for formatting a cycle that has been detected. Output is formatted as
-// {importReference1} -> {importReference2} -> {importReference3} -> {importReference1}, where {importReference1} are importReference detailed info
-func formatImportCycle(end *resolutionContextTree) string {
-	cycle := resolveImportReference(end.importReference)
-	for end.parentNode != nil {
-		end = end.parentNode
-		cycle = fmt.Sprintf("%s -> %s", resolveImportReference(end.importReference), cycle)
+	if hasCycle {
+		return fmt.Errorf("devfile has an cycle in references: %v", cycle)
 	}
-	return cycle
+	return nil
 }
 
 func resolveImportReference(importReference v1.ImportReference) string {