Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger page breaks if branch regex has invalid regex format #2201

Closed
2 tasks done
dheeth opened this issue Aug 22, 2022 · 0 comments · Fixed by devtron-labs/dashboard#476
Closed
2 tasks done

Trigger page breaks if branch regex has invalid regex format #2201

dheeth opened this issue Aug 22, 2022 · 0 comments · Fixed by devtron-labs/dashboard#476
Assignees
Labels
bug Something isn't working

Comments

@dheeth
Copy link
Contributor

dheeth commented Aug 22, 2022

Checklist:

  • I've searched in the docs and FAQ for my answer
  • I've included steps to reproduce the bug.

Describe the bug

If invalid regex is given in branch regex page, trigger page breaks after that

To Reproduce

  1. Create a workflow with branch regex
  2. Enter regex as "*" which is invalid
  3. Save and try to trigger using build and deploy page

Expected behavior

It shouldn't break, either validate before save or show an error during trigger that regex is invalid

Current behavior

Trigger page gets broken when we try to trigger with invalid regex

AB#130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants