Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bows still fire after switching the held slot while holding #676

Closed
ItsZodiaX opened this issue Oct 5, 2022 · 1 comment · Fixed by #585
Closed

Bows still fire after switching the held slot while holding #676

ItsZodiaX opened this issue Oct 5, 2022 · 1 comment · Fixed by #585
Labels
bug Something isn't working
Milestone
v0.10.0

Comments

@ItsZodiaX
Copy link
Contributor

vanilla vs df
@Blackjack200
Copy link
Contributor

i think the direct way to solve that is

change

dragonfly/server/session/player.go

Line 661 in 4113479

s.c.ReleaseItem()

to something just like

p.usingItem.CAS(true, false)

in

dragonfly/server/player/player.go

Line 1403 in 4113479

if !p.usingItem.CAS(true, false) || !p.canRelease() || !p.GameMode().AllowsInteraction() {

@Sandertv Sandertv added the bug Something isn't working label Oct 22, 2022
@T14Raptor T14Raptor mentioned this issue May 26, 2023
Closed
@Sandertv Sandertv changed the title Bow still able to release after switched item slot Bows still fire after switching the held slot while holding Nov 26, 2024
@Sandertv Sandertv added this to the v0.10.0 milestone Nov 26, 2024
@Sandertv Sandertv linked a pull request Nov 26, 2024 that will close this issue
Added a held slot handler #585
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging a pull request may close this issue.

Added a held slot handler df-mc/dragonfly
3 participants
@Sandertv @ItsZodiaX @Blackjack200