Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS: address reviews #354

Closed
elboyran opened this issue Sep 20, 2022 · 4 comments
Closed

JOSS: address reviews #354

elboyran opened this issue Sep 20, 2022 · 4 comments
Assignees

Comments

@elboyran
Copy link
Contributor

Address the JOSS reviews

@gcroci2
Copy link
Contributor

gcroci2 commented Sep 20, 2022

I opened PR #355

@elboyran
Copy link
Contributor Author

elboyran commented Oct 6, 2022

@gcroci2, @egpbos, @cwmeijer , @loostrum, @geek-yang would any/some of you have time to address also the unchecked check boxes by each of the 2 reviewers (despite the very uninformative reviews...)? And also the automated editorialbot suggestions?

@egpbos
Copy link
Member

egpbos commented Oct 19, 2022

So

  1. an installation instruction should be added (pip install dianna, basically? the reviewer says "for newbies", so maybe they also want to see that you first must install python, pip and only then install dianna?) and
  2. a "functionality" explanation should be added, so I guess a basic usage example?
  3. Depending on whether sara-02 can run the tests now, something may need to be added there as well?

@cwmeijer
Copy link
Member

cwmeijer commented Nov 1, 2022

Outdated and duplicate of #367 .

@cwmeijer cwmeijer closed this as completed Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants